From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: wsd_upstream@mediatek.com,
open list <linux-kernel@vger.kernel.org>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
Libo Kang <Libo.Kang@mediatek.com>,
yf.wang@mediatek.com, Miles Chen <miles.chen@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>, Ning Li <ning.li@mediatek.com>
Subject: Re: [PATCH] iommu/dma: Fix race condition during iova_domain initialization
Date: Wed, 22 Jun 2022 15:42:08 +0200 [thread overview]
Message-ID: <YrMcMOVSQtLqJ3kp@8bytes.org> (raw)
In-Reply-To: <a0f0d3da-6992-7033-5262-156ffa5316e7@arm.com>
On Wed, Jun 22, 2022 at 02:27:57PM +0100, Robin Murphy wrote:
> Apologies, I did spot this before, I've just been tied up with other things
> and dropping everything non-critical on the floor, so didn't get round to
> replying before it slipped my mind again.
>
> In summary, I hate it, but mostly because the whole situation of calling
> iommu_probe_device off the back of driver probe is fundamentally broken. I'm
> still a few steps away from fixing that properly, at which point I can just
> as well rip all these little bodges out again. If it really does need
> mitigating in the meantime (i.e. this is real-world async probe, not just
> some contrived testcase), then I can't easily think of any cleaner hack, so,
>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
Alright, applied this now.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: yf.wang@mediatek.com, Miles Chen <miles.chen@mediatek.com>,
wsd_upstream@mediatek.com,
open list <linux-kernel@vger.kernel.org>,
Libo Kang <Libo.Kang@mediatek.com>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Ning Li <ning.li@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] iommu/dma: Fix race condition during iova_domain initialization
Date: Wed, 22 Jun 2022 15:42:08 +0200 [thread overview]
Message-ID: <YrMcMOVSQtLqJ3kp@8bytes.org> (raw)
In-Reply-To: <a0f0d3da-6992-7033-5262-156ffa5316e7@arm.com>
On Wed, Jun 22, 2022 at 02:27:57PM +0100, Robin Murphy wrote:
> Apologies, I did spot this before, I've just been tied up with other things
> and dropping everything non-critical on the floor, so didn't get round to
> replying before it slipped my mind again.
>
> In summary, I hate it, but mostly because the whole situation of calling
> iommu_probe_device off the back of driver probe is fundamentally broken. I'm
> still a few steps away from fixing that properly, at which point I can just
> as well rip all these little bodges out again. If it really does need
> mitigating in the meantime (i.e. this is real-world async probe, not just
> some contrived testcase), then I can't easily think of any cleaner hack, so,
>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
Alright, applied this now.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: yf.wang@mediatek.com, Miles Chen <miles.chen@mediatek.com>,
wsd_upstream@mediatek.com,
open list <linux-kernel@vger.kernel.org>,
Libo Kang <Libo.Kang@mediatek.com>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Ning Li <ning.li@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] iommu/dma: Fix race condition during iova_domain initialization
Date: Wed, 22 Jun 2022 15:42:08 +0200 [thread overview]
Message-ID: <YrMcMOVSQtLqJ3kp@8bytes.org> (raw)
In-Reply-To: <a0f0d3da-6992-7033-5262-156ffa5316e7@arm.com>
On Wed, Jun 22, 2022 at 02:27:57PM +0100, Robin Murphy wrote:
> Apologies, I did spot this before, I've just been tied up with other things
> and dropping everything non-critical on the floor, so didn't get round to
> replying before it slipped my mind again.
>
> In summary, I hate it, but mostly because the whole situation of calling
> iommu_probe_device off the back of driver probe is fundamentally broken. I'm
> still a few steps away from fixing that properly, at which point I can just
> as well rip all these little bodges out again. If it really does need
> mitigating in the meantime (i.e. this is real-world async probe, not just
> some contrived testcase), then I can't easily think of any cleaner hack, so,
>
> Acked-by: Robin Murphy <robin.murphy@arm.com>
Alright, applied this now.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-22 13:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 12:07 [PATCH] iommu/dma: Fix race condition during iova_domain initialization yf.wang--- via iommu
2022-05-30 12:07 ` yf.wang
2022-05-30 12:07 ` yf.wang
2022-05-30 12:07 ` yf.wang
2022-06-09 17:04 ` Miles Chen via iommu
2022-06-09 17:04 ` Miles Chen
2022-06-09 17:04 ` Miles Chen
2022-06-09 17:04 ` Miles Chen
2022-06-22 12:46 ` Joerg Roedel
2022-06-22 12:46 ` Joerg Roedel
2022-06-22 12:46 ` Joerg Roedel
2022-06-22 13:27 ` Robin Murphy
2022-06-22 13:27 ` Robin Murphy
2022-06-22 13:27 ` Robin Murphy
2022-06-22 13:42 ` Joerg Roedel [this message]
2022-06-22 13:42 ` Joerg Roedel
2022-06-22 13:42 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrMcMOVSQtLqJ3kp@8bytes.org \
--to=joro@8bytes.org \
--cc=Libo.Kang@mediatek.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=miles.chen@mediatek.com \
--cc=ning.li@mediatek.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=wsd_upstream@mediatek.com \
--cc=yf.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.