From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: thomas.lendacky@amd.com, ashish.kalra@amd.com,
linux-kernel@vger.kernel.org, vasant.hegde@amd.com,
iommu@lists.linux-foundation.org, robin.murphy@arm.com
Subject: Re: [PATCH v3 7/7] iommu/amd: Do not support IOMMUv2 APIs when SNP is enabled
Date: Thu, 23 Jun 2022 10:23:57 +0200 [thread overview]
Message-ID: <YrQjHYsEIGN0mtO2@8bytes.org> (raw)
In-Reply-To: <20220622171131.11870-8-suravee.suthikulpanit@amd.com>
On Wed, Jun 22, 2022 at 12:11:31PM -0500, Suravee Suthikulpanit wrote:
> bool amd_iommu_v2_supported(void)
> {
> - return amd_iommu_v2_present;
> + /*
> + * Since DTE[Mode]=0 is prohibited on SNP-enabled system
> + * (i.e. EFR[SNPSup]=1), IOMMUv2 page table cannot be used without
> + * setting up IOMMUv1 page table.
> + */
> + return amd_iommu_v2_present && !amd_iommu_snp_en;
IOMMU_v2 APIs could actually be supported with GIOV and IOMMUv2
page-tables in-use, no?
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
robin.murphy@arm.com, ashish.kalra@amd.com, vasant.hegde@amd.com,
thomas.lendacky@amd.com
Subject: Re: [PATCH v3 7/7] iommu/amd: Do not support IOMMUv2 APIs when SNP is enabled
Date: Thu, 23 Jun 2022 10:23:57 +0200 [thread overview]
Message-ID: <YrQjHYsEIGN0mtO2@8bytes.org> (raw)
In-Reply-To: <20220622171131.11870-8-suravee.suthikulpanit@amd.com>
On Wed, Jun 22, 2022 at 12:11:31PM -0500, Suravee Suthikulpanit wrote:
> bool amd_iommu_v2_supported(void)
> {
> - return amd_iommu_v2_present;
> + /*
> + * Since DTE[Mode]=0 is prohibited on SNP-enabled system
> + * (i.e. EFR[SNPSup]=1), IOMMUv2 page table cannot be used without
> + * setting up IOMMUv1 page table.
> + */
> + return amd_iommu_v2_present && !amd_iommu_snp_en;
IOMMU_v2 APIs could actually be supported with GIOV and IOMMUv2
page-tables in-use, no?
Regards,
Joerg
next prev parent reply other threads:[~2022-06-23 8:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 17:11 [PATCH v3 0/7] iommu/amd: Enforce IOMMU restrictions for SNP-enabled system Suravee Suthikulpanit via iommu
2022-06-22 17:11 ` Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 1/7] iommu/amd: Warn when found inconsistency EFR mask Suravee Suthikulpanit via iommu
2022-06-22 17:11 ` Suravee Suthikulpanit
2022-06-23 8:22 ` Joerg Roedel
2022-06-23 8:22 ` Joerg Roedel
2022-06-29 11:50 ` Suthikulpanit, Suravee via iommu
2022-06-29 11:50 ` Suthikulpanit, Suravee
2022-06-22 17:11 ` [PATCH v3 2/7] iommu/amd: Process all IVHDs before enabling IOMMU features Suravee Suthikulpanit via iommu
2022-06-22 17:11 ` Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 3/7] iommu/amd: Introduce an iommu variable for tracking SNP support status Suravee Suthikulpanit via iommu
2022-06-22 17:11 ` Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 4/7] iommu/amd: Introduce function to check and enable SNP Suravee Suthikulpanit via iommu
2022-06-22 17:11 ` Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 5/7] iommu/amd: Set translation valid bit only when IO page tables are in use Suravee Suthikulpanit via iommu
2022-06-22 17:11 ` Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 6/7] iommu/amd: Do not support IOMMU_DOMAIN_IDENTITY after SNP is enabled Suravee Suthikulpanit via iommu
2022-06-22 17:11 ` Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 7/7] iommu/amd: Do not support IOMMUv2 APIs when " Suravee Suthikulpanit via iommu
2022-06-22 17:11 ` Suravee Suthikulpanit
2022-06-23 8:23 ` Joerg Roedel [this message]
2022-06-23 8:23 ` Joerg Roedel
2022-06-29 11:54 ` Suthikulpanit, Suravee via iommu
2022-06-29 11:54 ` Suthikulpanit, Suravee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrQjHYsEIGN0mtO2@8bytes.org \
--to=joro@8bytes.org \
--cc=ashish.kalra@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=thomas.lendacky@amd.com \
--cc=vasant.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.