From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Mikhail Sennikovsky <mikhail.sennikovskii@ionos.com>
Cc: netfilter-devel@vger.kernel.org, mikhail.sennikovsky@gmail.com
Subject: Re: [PATCH 3/6] tests/conntrack: invalid protocol values
Date: Thu, 23 Jun 2022 21:29:41 +0200 [thread overview]
Message-ID: <YrS/JZGtFo0EzibA@salvia> (raw)
In-Reply-To: <20220623175000.49259-4-mikhail.sennikovskii@ionos.com>
On Thu, Jun 23, 2022 at 07:49:57PM +0200, Mikhail Sennikovsky wrote:
> Testcases covering passing invalid protocol values via -p parameter.
> * -p 256 should fail
> * -p foo should fail
> which does not work properly at the moment.
> Fix included in the next commit.
Please, collapse this to next patch 4/6 in v2.
> Signed-off-by: Mikhail Sennikovsky <mikhail.sennikovskii@ionos.com>
> ---
> tests/conntrack/testsuite/00create | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/conntrack/testsuite/00create b/tests/conntrack/testsuite/00create
> index 9962e23..9fb3a0b 100644
> --- a/tests/conntrack/testsuite/00create
> +++ b/tests/conntrack/testsuite/00create
> @@ -61,3 +61,8 @@
> -D -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; OK
> # delete again
> -D -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; BAD
> +# Invalid protocol values
> +# 256 should fail
> +-I -t 10 -s 1.1.1.1 -d 2.2.2.2 -r 2.2.2.2 -q 1.1.1.1 -p 256 ; BAD
> +# take some invalid protocol name
> +-I -t 10 -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p foo ; BAD
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-06-23 19:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 17:49 [PATCH 0/6] conntrack: fixes for handling unknown protocols Mikhail Sennikovsky
2022-06-23 17:49 ` [PATCH 1/6] tests/conntrack: ct create for " Mikhail Sennikovsky
2022-06-23 17:49 ` [PATCH 2/6] conntrack: set reply l4 proto for unknown protocol Mikhail Sennikovsky
2022-06-23 19:30 ` Pablo Neira Ayuso
2022-06-23 17:49 ` [PATCH 3/6] tests/conntrack: invalid protocol values Mikhail Sennikovsky
2022-06-23 19:29 ` Pablo Neira Ayuso [this message]
2022-06-23 17:49 ` [PATCH 4/6] conntrack: fix protocol number parsing Mikhail Sennikovsky
2022-06-23 19:29 ` Pablo Neira Ayuso
2022-06-23 17:49 ` [PATCH 5/6] tests/conntrack: ct -o save for unknown protocols Mikhail Sennikovsky
2022-06-23 19:28 ` Pablo Neira Ayuso
2022-06-23 17:50 ` [PATCH 6/6] conntrack: fix -o save dump " Mikhail Sennikovsky
2022-06-23 19:27 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrS/JZGtFo0EzibA@salvia \
--to=pablo@netfilter.org \
--cc=mikhail.sennikovskii@ionos.com \
--cc=mikhail.sennikovsky@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.