From: Mark Brown <broonie@kernel.org>
To: Daniel Mack <daniel@zonque.org>
Cc: devicetree@vger.kernel.org, ryan.lee.analog@gmail.com,
robh+dt@kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 6/8] ASoC: max98396: Fix register access for PCM format settings
Date: Fri, 24 Jun 2022 13:52:44 +0100 [thread overview]
Message-ID: <YrWznD63aJvCLkXO@sirena.org.uk> (raw)
In-Reply-To: <20220624104712.1934484-7-daniel@zonque.org>
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
On Fri, Jun 24, 2022 at 12:47:10PM +0200, Daniel Mack wrote:
> max98396_dai_set_fmt() modifes register 2041 and touches bits in the mask
> 0x3a. Make sure to use the right mask for that operation.
This is a fix so should be at the start of the series, ensuring it has
no dependencies on anything else in the series.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Daniel Mack <daniel@zonque.org>
Cc: ryan.lee.analog@gmail.com, robh+dt@kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 6/8] ASoC: max98396: Fix register access for PCM format settings
Date: Fri, 24 Jun 2022 13:52:44 +0100 [thread overview]
Message-ID: <YrWznD63aJvCLkXO@sirena.org.uk> (raw)
In-Reply-To: <20220624104712.1934484-7-daniel@zonque.org>
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
On Fri, Jun 24, 2022 at 12:47:10PM +0200, Daniel Mack wrote:
> max98396_dai_set_fmt() modifes register 2041 and touches bits in the mask
> 0x3a. Make sure to use the right mask for that operation.
This is a fix so should be at the start of the series, ensuring it has
no dependencies on anything else in the series.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-24 12:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 10:47 [PATCH 0/8] ASoC: max98396: Some assorted fixes and additions Daniel Mack
2022-06-24 10:47 ` Daniel Mack
2022-06-24 10:47 ` [PATCH 1/8] ASoC: dt-bindings: max98396: add voltage supplies Daniel Mack
2022-06-24 10:47 ` Daniel Mack
2022-06-24 10:47 ` [PATCH 2/8] ASoC: dt-bindings: max98396: Add #sound-dai-cells Daniel Mack
2022-06-24 10:47 ` Daniel Mack
2022-06-24 17:26 ` Rob Herring
2022-06-24 17:26 ` Rob Herring
2022-06-24 10:47 ` [PATCH 3/8] ASoC: dt-bindings: max98396: Document adi,bypass-slot-no Daniel Mack
2022-06-24 10:47 ` Daniel Mack
2022-06-24 12:42 ` Mark Brown
2022-06-24 12:42 ` Mark Brown
2022-06-24 10:47 ` [PATCH 4/8] ASoC: max98396: add voltage regulators Daniel Mack
2022-06-24 10:47 ` Daniel Mack
2022-06-24 10:47 ` [PATCH 5/8] ASoC: max98396: Improve some error prints Daniel Mack
2022-06-24 10:47 ` Daniel Mack
2022-06-24 10:47 ` [PATCH 6/8] ASoC: max98396: Fix register access for PCM format settings Daniel Mack
2022-06-24 10:47 ` Daniel Mack
2022-06-24 12:52 ` Mark Brown [this message]
2022-06-24 12:52 ` Mark Brown
2022-06-24 10:47 ` [PATCH 7/8] ASoC: max98396: Implement DSP speaker monitor Daniel Mack
2022-06-24 10:47 ` Daniel Mack
2022-06-24 10:47 ` [PATCH 8/8] ASoC: max98396: Fix TDM mode BSEL settings Daniel Mack
2022-06-24 10:47 ` Daniel Mack
2022-06-24 11:34 ` Daniel Mack
2022-06-24 11:34 ` Daniel Mack
2022-06-24 12:54 ` Mark Brown
2022-06-24 12:54 ` Mark Brown
2022-06-27 20:19 ` (subset) [PATCH 0/8] ASoC: max98396: Some assorted fixes and additions Mark Brown
2022-06-27 20:19 ` Mark Brown
2022-06-27 20:26 ` Daniel Mack
2022-06-27 20:26 ` Daniel Mack
2022-06-27 22:23 ` Mark Brown
2022-06-27 22:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrWznD63aJvCLkXO@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ryan.lee.analog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.