From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Maxime Ripard <mripard@kernel.org>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm: logicvc: fix error code in logicvc_layer_init()
Date: Fri, 24 Jun 2022 16:35:51 +0200 [thread overview]
Message-ID: <YrXLx8AXRObZEbVi@aptenodytes> (raw)
In-Reply-To: <Yqh6VdNiDvJYMOQ+@kili>
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
Hi,
On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> Return -EINVAL if logicvc_layer_formats_lookup() fails. Don't return
> success.
>
> Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the fix!
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Paul
> ---
> drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
> index bae1c7f99569..9c94b67afbed 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc,
> if (!formats) {
> drm_err(drm_dev, "Failed to lookup formats for layer #%d\n",
> index);
> + ret = -EINVAL;
> goto error;
> }
>
> --
> 2.35.1
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm: logicvc: fix error code in logicvc_layer_init()
Date: Fri, 24 Jun 2022 16:35:51 +0200 [thread overview]
Message-ID: <YrXLx8AXRObZEbVi@aptenodytes> (raw)
In-Reply-To: <Yqh6VdNiDvJYMOQ+@kili>
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
Hi,
On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> Return -EINVAL if logicvc_layer_formats_lookup() fails. Don't return
> success.
>
> Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the fix!
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Paul
> ---
> drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
> index bae1c7f99569..9c94b67afbed 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc,
> if (!formats) {
> drm_err(drm_dev, "Failed to lookup formats for layer #%d\n",
> index);
> + ret = -EINVAL;
> goto error;
> }
>
> --
> 2.35.1
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-24 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 12:08 [PATCH] drm: logicvc: fix error code in logicvc_layer_init() Dan Carpenter
2022-06-14 12:08 ` Dan Carpenter
2022-06-24 14:35 ` Paul Kocialkowski [this message]
2022-06-24 14:35 ` Paul Kocialkowski
2022-06-24 15:25 ` Paul Kocialkowski
2022-06-24 15:25 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrXLx8AXRObZEbVi@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.