Re: [PATCH v5 2/2] drm: lcdif: Add support for i.MX8MP LCDIF variant

[Sam Ravnborg <sam@ravnborg.org>]

> > +
> > +static int lcdif_rpm_resume(struct device *dev)
> > +{
> > +	struct drm_device *drm = dev_get_drvdata(dev);
> > +	struct lcdif_drm_private *lcdif = drm->dev_private;
> > +
> > +	/* These clock supply the Control Bus, APB, APBH Ctrl Registers */
> > +	clk_prepare_enable(lcdif->clk_axi);
> > +	/* These clock supply the System Bus, AXI, Write Path, LFIFO */
> > +	clk_prepare_enable(lcdif->clk_disp_axi);
> > +	/* These clock supply the DISPLAY CLOCK Domain */
> > +	clk_prepare_enable(lcdif->clk);
> > +
> > +	return 0;
> > +}
> > +
> 
> To avoid unused function warnings, suspend and resume should be under
> #ifdef CONFIG_PM_SLEEP

If SET_RUNTIME_PM_OPS is used then it is good practice to annotate the
functions __maybe_unused and no #ifdef - then they see build coverage also
without PM_SLEEP but they are discarded so do not consume memory if not used.

	Sam