From: Andrew Lunn <andrew@lunn.ch>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
David Wu <david.wu@rock-chips.com>,
kernel@collabora.com
Subject: Re: [PATCH 1/3] net: ethernet: stmmac: dwmac-rk: Disable delayline if it is invalid
Date: Fri, 24 Jun 2022 18:52:26 +0200 [thread overview]
Message-ID: <YrXryvTpnSIOyUTD@lunn.ch> (raw)
In-Reply-To: <20220624162956.vn4b3va5cz2agvrb@mercury.elektranox.org>
> > So it seems to me you are changing the documented default. You cannot
> > do that, this is ABI.
>
> Right. I suppose we either need a disable value or an extra property. I
> can add support for supplying (-1) from DT. Does that sounds ok to
> everyone?
I'm missing the big picture.
Does the hardware you are adding not support delays? If so, rather
than using the defaults, don't do anything. And if a value is
supplied, -EINVAL?
Andrew
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
David Wu <david.wu@rock-chips.com>,
kernel@collabora.com
Subject: Re: [PATCH 1/3] net: ethernet: stmmac: dwmac-rk: Disable delayline if it is invalid
Date: Fri, 24 Jun 2022 18:52:26 +0200 [thread overview]
Message-ID: <YrXryvTpnSIOyUTD@lunn.ch> (raw)
In-Reply-To: <20220624162956.vn4b3va5cz2agvrb@mercury.elektranox.org>
> > So it seems to me you are changing the documented default. You cannot
> > do that, this is ABI.
>
> Right. I suppose we either need a disable value or an extra property. I
> can add support for supplying (-1) from DT. Does that sounds ok to
> everyone?
I'm missing the big picture.
Does the hardware you are adding not support delays? If so, rather
than using the defaults, don't do anything. And if a value is
supplied, -EINVAL?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
David Wu <david.wu@rock-chips.com>,
kernel@collabora.com
Subject: Re: [PATCH 1/3] net: ethernet: stmmac: dwmac-rk: Disable delayline if it is invalid
Date: Fri, 24 Jun 2022 18:52:26 +0200 [thread overview]
Message-ID: <YrXryvTpnSIOyUTD@lunn.ch> (raw)
In-Reply-To: <20220624162956.vn4b3va5cz2agvrb@mercury.elektranox.org>
> > So it seems to me you are changing the documented default. You cannot
> > do that, this is ABI.
>
> Right. I suppose we either need a disable value or an extra property. I
> can add support for supplying (-1) from DT. Does that sounds ok to
> everyone?
I'm missing the big picture.
Does the hardware you are adding not support delays? If so, rather
than using the defaults, don't do anything. And if a value is
supplied, -EINVAL?
Andrew
next prev parent reply other threads:[~2022-06-24 16:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 16:28 [PATCH 0/3] RK3588 Ethernet Support Sebastian Reichel
2022-06-23 16:28 ` Sebastian Reichel
2022-06-23 16:28 ` Sebastian Reichel
2022-06-23 16:28 ` [PATCH 1/3] net: ethernet: stmmac: dwmac-rk: Disable delayline if it is invalid Sebastian Reichel
2022-06-23 16:28 ` Sebastian Reichel
2022-06-23 16:28 ` Sebastian Reichel
2022-06-24 11:18 ` Andrew Lunn
2022-06-24 11:18 ` Andrew Lunn
2022-06-24 11:18 ` Andrew Lunn
2022-06-24 16:29 ` Sebastian Reichel
2022-06-24 16:29 ` Sebastian Reichel
2022-06-24 16:29 ` Sebastian Reichel
2022-06-24 16:52 ` Andrew Lunn [this message]
2022-06-24 16:52 ` Andrew Lunn
2022-06-24 16:52 ` Andrew Lunn
2022-06-24 17:35 ` Sebastian Reichel
2022-06-24 17:35 ` Sebastian Reichel
2022-06-24 17:35 ` Sebastian Reichel
2022-06-24 17:37 ` Andrew Lunn
2022-06-24 17:37 ` Andrew Lunn
2022-06-24 17:37 ` Andrew Lunn
2022-06-24 20:15 ` Sebastian Reichel
2022-06-24 20:15 ` Sebastian Reichel
2022-06-24 20:15 ` Sebastian Reichel
2022-06-24 23:43 ` Peter Geis
2022-06-24 23:43 ` Peter Geis
2022-06-24 23:43 ` Peter Geis
2022-06-25 6:50 ` Andrew Lunn
2022-06-25 6:50 ` Andrew Lunn
2022-06-25 6:50 ` Andrew Lunn
2022-06-23 16:28 ` [PATCH 2/3] net: ethernet: stmmac: dwmac-rk: Add gmac support for rk3588 Sebastian Reichel
2022-06-23 16:28 ` Sebastian Reichel
2022-06-23 16:28 ` Sebastian Reichel
2022-06-23 16:28 ` [PATCH 3/3] dt-bindings: net: rockchip-dwmac: add rk3588 gmac compatible Sebastian Reichel
2022-06-23 16:28 ` Sebastian Reichel
2022-06-23 16:28 ` Sebastian Reichel
2022-06-26 20:18 ` Krzysztof Kozlowski
2022-06-26 20:18 ` Krzysztof Kozlowski
2022-06-26 20:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrXryvTpnSIOyUTD@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=david.wu@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.