Re: [PATCH 08/28] drm/via: Add via_cursor.c

[Sam Ravnborg <sam@ravnborg.org>]

Hi Kevin,

a few nitpicks in the following.

	Sam

On Fri, Jun 24, 2022 at 03:26:13PM -0500, Kevin Brace wrote:
> From: Kevin Brace <kevinbrace@bracecomputerlab.com>
> 
> Signed-off-by: Kevin Brace <kevinbrace@bracecomputerlab.com>
> ---
>  drivers/gpu/drm/via/via_cursor.c | 419 +++++++++++++++++++++++++++++++
>  1 file changed, 419 insertions(+)
>  create mode 100644 drivers/gpu/drm/via/via_cursor.c

> 
> +	DRM_DEBUG_KMS("Exiting %s.\n", __func__);
The use of the DRM_* for logging is deprecated these days.
The recommended variants are names drm_dbg_* and friends.
They require a drm_device, and in lack of this use dev_dbg or fallback
to pr_*

This applies for all the driver, not only this file.

> +
> +const struct drm_plane_funcs via_cursor_drm_plane_funcs = {
> +	.update_plane = drm_atomic_helper_update_plane,
> +	.disable_plane = drm_atomic_helper_disable_plane,
> +	.destroy = drm_plane_cleanup,
> +	.reset = drm_atomic_helper_plane_reset,
> +	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
> +	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
> +};
> +
> +const uint32_t via_cursor_formats[] = {
> +	DRM_FORMAT_ARGB8888,
> +};
> +
> +const unsigned int via_cursor_formats_size =
> +				ARRAY_SIZE(via_cursor_formats);

The three variables above does not reference anything in this file
and can be moved to the file with the single user.

	Sam