From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Melissa Wen <mwen@igalia.com>
Cc: tzimmermann@suse.de, airlied@linux.ie, Rodrigo.Siqueira@amd.com,
dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
nikola.cornij@amd.com, bhawanpreet.lakha@amd.com,
sunpeng.li@amd.com, alex.hung@amd.com,
amd-gfx@lists.freedesktop.org, daniel@ffwll.ch,
alexander.deucher@amd.com, seanpaul@chromium.org,
nicholas.kazlauskas@amd.com, harry.wentland@amd.com,
christian.koenig@amd.com, sungjoon.kim@amd.com
Subject: Re: [RFC PATCH 4/5] drm/drm_color_mgmt: add 3D LUT to color mgmt properties
Date: Mon, 27 Jun 2022 15:18:02 +0300 [thread overview]
Message-ID: <Yrmf+mWk13qkcsfs@intel.com> (raw)
In-Reply-To: <20220619223104.667413-5-mwen@igalia.com>
On Sun, Jun 19, 2022 at 09:31:03PM -0100, Melissa Wen wrote:
> Add 3D LUT for gammar correction using a 3D lookup table. The position
> in the color correction pipeline where 3D LUT is applied depends on hw
> design, being after CTM or gamma. If just after CTM, a shaper lut must
> be set to shape the content for a non-linear space. That details should
> be handled by the driver according to its color capabilities.
I also cooked up a WIP 3D LUT support some time ago for Intel hw:
https://github.com/vsyrjala/linux/commits/3dlut
But that dried up due to having no userspace for it.
I also cooked up some basic igts for it:
https://patchwork.freedesktop.org/series/90165/
<snip>
> + * “LUT3D”:
> + * Blob property to set the 3D LUT mapping pixel data after the color
> + * transformation matrix and before gamma 1D lut correction.
On Intel hw the 3DLUT is after the gamma LUT in the pipeline, which is
where I placed it in my branch.
There is now some discussion happening about exposing some
kind of color pipeline description/configuration properties:
https://gitlab.freedesktop.org/pq/color-and-hdr/-/issues/11
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Melissa Wen <mwen@igalia.com>
Cc: tzimmermann@suse.de, airlied@linux.ie, Rodrigo.Siqueira@amd.com,
dri-devel@lists.freedesktop.org, Xinhui.Pan@amd.com,
nikola.cornij@amd.com, bhawanpreet.lakha@amd.com,
sunpeng.li@amd.com, alex.hung@amd.com,
amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
seanpaul@chromium.org, nicholas.kazlauskas@amd.com,
christian.koenig@amd.com, sungjoon.kim@amd.com
Subject: Re: [RFC PATCH 4/5] drm/drm_color_mgmt: add 3D LUT to color mgmt properties
Date: Mon, 27 Jun 2022 15:18:02 +0300 [thread overview]
Message-ID: <Yrmf+mWk13qkcsfs@intel.com> (raw)
In-Reply-To: <20220619223104.667413-5-mwen@igalia.com>
On Sun, Jun 19, 2022 at 09:31:03PM -0100, Melissa Wen wrote:
> Add 3D LUT for gammar correction using a 3D lookup table. The position
> in the color correction pipeline where 3D LUT is applied depends on hw
> design, being after CTM or gamma. If just after CTM, a shaper lut must
> be set to shape the content for a non-linear space. That details should
> be handled by the driver according to its color capabilities.
I also cooked up a WIP 3D LUT support some time ago for Intel hw:
https://github.com/vsyrjala/linux/commits/3dlut
But that dried up due to having no userspace for it.
I also cooked up some basic igts for it:
https://patchwork.freedesktop.org/series/90165/
<snip>
> + * “LUT3D”:
> + * Blob property to set the 3D LUT mapping pixel data after the color
> + * transformation matrix and before gamma 1D lut correction.
On Intel hw the 3DLUT is after the gamma LUT in the pipeline, which is
where I placed it in my branch.
There is now some discussion happening about exposing some
kind of color pipeline description/configuration properties:
https://gitlab.freedesktop.org/pq/color-and-hdr/-/issues/11
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-06-27 12:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-19 22:30 [RFC PATCH 0/5] DRM CRTC 3D LUT interface for AMD DCN Melissa Wen
2022-06-19 22:31 ` [RFC PATCH 1/5] Documentation/amdgpu_dm: Add DM color correction documentation Melissa Wen
2022-06-28 20:32 ` Harry Wentland
2022-06-19 22:31 ` [RFC PATCH 2/5] Documentation/amdgpu/display: add DC color caps info Melissa Wen
2022-06-28 21:29 ` Harry Wentland
2022-07-12 15:05 ` Melissa Wen
2022-07-12 15:05 ` Melissa Wen
2022-06-19 22:31 ` [RFC PATCH 3/5] drm/drm_color_mgmt: add shaper LUT to color mgmt properties Melissa Wen
2022-06-19 22:31 ` [RFC PATCH 4/5] drm/drm_color_mgmt: add 3D " Melissa Wen
2022-06-24 21:40 ` Daniel Vetter
2022-06-24 21:40 ` Daniel Vetter
2022-06-27 12:18 ` Ville Syrjälä [this message]
2022-06-27 12:18 ` Ville Syrjälä
2022-06-28 19:41 ` Harry Wentland
2022-06-28 19:41 ` Harry Wentland
2022-07-12 14:53 ` Melissa Wen
2022-07-12 14:53 ` Melissa Wen
2023-01-09 12:50 ` Joshua Ashton
2023-01-09 12:50 ` Joshua Ashton
2022-06-28 21:34 ` Harry Wentland
2022-07-12 15:01 ` Melissa Wen
2022-07-12 15:01 ` Melissa Wen
2022-06-19 22:31 ` [RFC PATCH 5/5] drm/amd/display: mapping new DRM 3D LUT properties to AMD hw blocks Melissa Wen
2022-06-28 20:12 ` [RFC PATCH 0/5] DRM CRTC 3D LUT interface for AMD DCN Harry Wentland
2022-07-12 16:16 ` Melissa Wen
2022-07-12 16:16 ` Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrmf+mWk13qkcsfs@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bhawanpreet.lakha@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=nikola.cornij@amd.com \
--cc=seanpaul@chromium.org \
--cc=sungjoon.kim@amd.com \
--cc=sunpeng.li@amd.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.