All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ARM: Silence proc-v7-bugs.c spam about disabled Spectre workarounds
Date: Tue, 28 Jun 2022 08:31:25 +0100	[thread overview]
Message-ID: <YrquTaGDYaEfBXjw@shell.armlinux.org.uk> (raw)
In-Reply-To: <253e9ec1-bcd8-c790-95b8-afbcc21e7163@collabora.com>

On Tue, Jun 28, 2022 at 10:23:06AM +0300, Dmitry Osipenko wrote:
> On 5/19/22 19:13, Dmitry Osipenko wrote:
> > Print message about disabled Spectre workarounds only once to stop
> > endless spam into KSMG each time CPU goes out from idling state.
> > This spam makes system unusable with CONFIG_HARDEN_BRANCH_PREDICTOR=n
> > for those who don't care about security and wants maximum performance.
> > 
> > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> > ---
> >  arch/arm/mm/proc-v7-bugs.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mm/proc-v7-bugs.c b/arch/arm/mm/proc-v7-bugs.c
> > index fb9f3eb6bf48..f9730eba0632 100644
> > --- a/arch/arm/mm/proc-v7-bugs.c
> > +++ b/arch/arm/mm/proc-v7-bugs.c
> > @@ -108,8 +108,7 @@ static unsigned int spectre_v2_install_workaround(unsigned int method)
> >  #else
> >  static unsigned int spectre_v2_install_workaround(unsigned int method)
> >  {
> > -	pr_info("CPU%u: Spectre V2: workarounds disabled by configuration\n",
> > -		smp_processor_id());
> > +	pr_info_once("Spectre V2: workarounds disabled by configuration\n");
> >  
> >  	return SPECTRE_VULNERABLE;
> >  }
> 
> Hello Russell,
> 
> Could you please apply this patch? I tried to use yours patch tracker
> today and it doesn't allow me to recover my password (server error: MAIL
> FROM command failed Detail: Space shortage).

That should now be working - thanks to apt needlessly consuming 200MB of
space. Please use the patch system, thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ARM: Silence proc-v7-bugs.c spam about disabled Spectre workarounds
Date: Tue, 28 Jun 2022 08:31:25 +0100	[thread overview]
Message-ID: <YrquTaGDYaEfBXjw@shell.armlinux.org.uk> (raw)
In-Reply-To: <253e9ec1-bcd8-c790-95b8-afbcc21e7163@collabora.com>

On Tue, Jun 28, 2022 at 10:23:06AM +0300, Dmitry Osipenko wrote:
> On 5/19/22 19:13, Dmitry Osipenko wrote:
> > Print message about disabled Spectre workarounds only once to stop
> > endless spam into KSMG each time CPU goes out from idling state.
> > This spam makes system unusable with CONFIG_HARDEN_BRANCH_PREDICTOR=n
> > for those who don't care about security and wants maximum performance.
> > 
> > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> > ---
> >  arch/arm/mm/proc-v7-bugs.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mm/proc-v7-bugs.c b/arch/arm/mm/proc-v7-bugs.c
> > index fb9f3eb6bf48..f9730eba0632 100644
> > --- a/arch/arm/mm/proc-v7-bugs.c
> > +++ b/arch/arm/mm/proc-v7-bugs.c
> > @@ -108,8 +108,7 @@ static unsigned int spectre_v2_install_workaround(unsigned int method)
> >  #else
> >  static unsigned int spectre_v2_install_workaround(unsigned int method)
> >  {
> > -	pr_info("CPU%u: Spectre V2: workarounds disabled by configuration\n",
> > -		smp_processor_id());
> > +	pr_info_once("Spectre V2: workarounds disabled by configuration\n");
> >  
> >  	return SPECTRE_VULNERABLE;
> >  }
> 
> Hello Russell,
> 
> Could you please apply this patch? I tried to use yours patch tracker
> today and it doesn't allow me to recover my password (server error: MAIL
> FROM command failed Detail: Space shortage).

That should now be working - thanks to apt needlessly consuming 200MB of
space. Please use the patch system, thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2022-06-28  7:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 16:13 [PATCH v1] ARM: Silence proc-v7-bugs.c spam about disabled Spectre workarounds Dmitry Osipenko
2022-05-19 16:13 ` Dmitry Osipenko
2022-06-28  7:23 ` Dmitry Osipenko
2022-06-28  7:23   ` Dmitry Osipenko
2022-06-28  7:31   ` Russell King (Oracle) [this message]
2022-06-28  7:31     ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YrquTaGDYaEfBXjw@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=dmitry.osipenko@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.