All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/bridge: Avoid uninitialized variable warning
@ 2022-07-04 10:55 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-07-04 10:55 UTC (permalink / raw)
  To: Maarten Lankhorst, Boris Brezillon
  Cc: Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter,
	Neil Armstrong, Jernej Skrabec, dri-devel, kernel-janitors

This code works, but technically it uses "num_in_bus_fmts" before it
has been initialized so it leads to static checker warnings and probably
KMEMsan warnings at run time.  Initialize the variable to zero to
silence the warning.

Fixes: f32df58acc68 ("drm/bridge: Add the necessary bits to support bus format negotiation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: initialize the variable instead, this keeps the original error codes.

 drivers/gpu/drm/drm_bridge.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index e275b4ca344b..d4601201f31d 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -846,8 +846,8 @@ static int select_bus_fmt_recursive(struct drm_bridge *first_bridge,
 				    struct drm_connector_state *conn_state,
 				    u32 out_bus_fmt)
 {
+	unsigned int i, num_in_bus_fmts = 0;
 	struct drm_bridge_state *cur_state;
-	unsigned int num_in_bus_fmts, i;
 	struct drm_bridge *prev_bridge;
 	u32 *in_bus_fmts;
 	int ret;
@@ -968,7 +968,7 @@ drm_atomic_bridge_chain_select_bus_fmts(struct drm_bridge *bridge,
 	struct drm_connector *conn = conn_state->connector;
 	struct drm_encoder *encoder = bridge->encoder;
 	struct drm_bridge_state *last_bridge_state;
-	unsigned int i, num_out_bus_fmts;
+	unsigned int i, num_out_bus_fmts = 0;
 	struct drm_bridge *last_bridge;
 	u32 *out_bus_fmts;
 	int ret = 0;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH v2] drm/bridge: Avoid uninitialized variable warning
@ 2022-07-04 10:55 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-07-04 10:55 UTC (permalink / raw)
  To: Maarten Lankhorst, Boris Brezillon
  Cc: Thomas Zimmermann, Neil Armstrong, David Airlie, dri-devel,
	kernel-janitors, Jernej Skrabec

This code works, but technically it uses "num_in_bus_fmts" before it
has been initialized so it leads to static checker warnings and probably
KMEMsan warnings at run time.  Initialize the variable to zero to
silence the warning.

Fixes: f32df58acc68 ("drm/bridge: Add the necessary bits to support bus format negotiation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: initialize the variable instead, this keeps the original error codes.

 drivers/gpu/drm/drm_bridge.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index e275b4ca344b..d4601201f31d 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -846,8 +846,8 @@ static int select_bus_fmt_recursive(struct drm_bridge *first_bridge,
 				    struct drm_connector_state *conn_state,
 				    u32 out_bus_fmt)
 {
+	unsigned int i, num_in_bus_fmts = 0;
 	struct drm_bridge_state *cur_state;
-	unsigned int num_in_bus_fmts, i;
 	struct drm_bridge *prev_bridge;
 	u32 *in_bus_fmts;
 	int ret;
@@ -968,7 +968,7 @@ drm_atomic_bridge_chain_select_bus_fmts(struct drm_bridge *bridge,
 	struct drm_connector *conn = conn_state->connector;
 	struct drm_encoder *encoder = bridge->encoder;
 	struct drm_bridge_state *last_bridge_state;
-	unsigned int i, num_out_bus_fmts;
+	unsigned int i, num_out_bus_fmts = 0;
 	struct drm_bridge *last_bridge;
 	u32 *out_bus_fmts;
 	int ret = 0;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: (subset) [PATCH v2] drm/bridge: Avoid uninitialized variable warning
  2022-07-04 10:55 ` Dan Carpenter
@ 2022-07-08 11:46   ` Maxime Ripard
  -1 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2022-07-08 11:46 UTC (permalink / raw)
  To: boris.brezillon, maarten.lankhorst, dan.carpenter
  Cc: Maxime Ripard, narmstrong, airlied, tzimmermann, mripard,
	jernej.skrabec, dri-devel, daniel, kernel-janitors

On Mon, 4 Jul 2022 13:55:40 +0300, Dan Carpenter wrote:
> This code works, but technically it uses "num_in_bus_fmts" before it
> has been initialized so it leads to static checker warnings and probably
> KMEMsan warnings at run time.  Initialize the variable to zero to
> silence the warning.
> 
> 

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: (subset) [PATCH v2] drm/bridge: Avoid uninitialized variable warning
@ 2022-07-08 11:46   ` Maxime Ripard
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2022-07-08 11:46 UTC (permalink / raw)
  To: boris.brezillon, maarten.lankhorst, dan.carpenter
  Cc: narmstrong, airlied, dri-devel, kernel-janitors, jernej.skrabec,
	tzimmermann, Maxime Ripard

On Mon, 4 Jul 2022 13:55:40 +0300, Dan Carpenter wrote:
> This code works, but technically it uses "num_in_bus_fmts" before it
> has been initialized so it leads to static checker warnings and probably
> KMEMsan warnings at run time.  Initialize the variable to zero to
> silence the warning.
> 
> 

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-08 11:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-04 10:55 [PATCH v2] drm/bridge: Avoid uninitialized variable warning Dan Carpenter
2022-07-04 10:55 ` Dan Carpenter
2022-07-08 11:46 ` (subset) " Maxime Ripard
2022-07-08 11:46   ` Maxime Ripard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.