All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] perf unwind: Fix uninitialized variable
@ 2022-06-07  0:08 Ian Rogers
  2022-06-07  0:26 ` Fangrui Song
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Ian Rogers @ 2022-06-07  0:08 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	linux-perf-users, linux-kernel, Sedat Dilek
  Cc: Ian Rogers, llvm, Fangrui Song, Sebastian Ullrich

ret may be uninitialized on error goto paths.

Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
Fixes: dc2cf4ca866f ("perf unwind: Fix segbase for ld.lld linked objects")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/util/unwind-libunwind-local.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
index 37622699c91a..6e5b8cce47bf 100644
--- a/tools/perf/util/unwind-libunwind-local.c
+++ b/tools/perf/util/unwind-libunwind-local.c
@@ -174,7 +174,7 @@ static int elf_section_address_and_offset(int fd, const char *name, u64 *address
 	Elf *elf;
 	GElf_Ehdr ehdr;
 	GElf_Shdr shdr;
-	int ret;
+	int ret = -1;
 
 	elf = elf_begin(fd, PERF_ELF_C_READ_MMAP, NULL);
 	if (elf == NULL)
-- 
2.36.1.255.ge46751e96f-goog


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-06-28 14:39 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-07  0:08 [PATCH] perf unwind: Fix uninitialized variable Ian Rogers
2022-06-07  0:26 ` Fangrui Song
2022-06-09 16:34   ` Arnaldo Carvalho de Melo
2022-06-07 18:12 ` Sedat Dilek
2022-06-08 19:29   ` Sedat Dilek
2022-06-07 18:59 ` [Linux v5.19-rc1] tools/perf/a.out remains after make -C tools/perf clean Sedat Dilek
2022-06-14 19:24   ` Arnaldo Carvalho de Melo
2022-06-14 22:11     ` Sedat Dilek
2022-06-26 15:31       ` Arnaldo Carvalho de Melo
2022-06-27  6:20         ` Sedat Dilek
2022-06-28 14:39         ` Arnaldo Carvalho de Melo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.