* [PATCH -next] Input: Remove unnecessary print function dev_err()
@ 2022-04-27 0:49 Yang Li
2022-06-29 5:51 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-04-27 0:49 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Yang Li, Abaci Robot
The print function dev_err() is redundant because
platform_get_irq() already prints an error.
Eliminate the follow coccicheck warning:
./drivers/input/joystick/sensehat-joystick.c:102:2-9: line 102 is
redundant because platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/input/joystick/sensehat-joystick.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/joystick/sensehat-joystick.c b/drivers/input/joystick/sensehat-joystick.c
index 5ad1fe4ff496..a84df39d3b2f 100644
--- a/drivers/input/joystick/sensehat-joystick.c
+++ b/drivers/input/joystick/sensehat-joystick.c
@@ -98,10 +98,8 @@ static int sensehat_joystick_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "Could not retrieve interrupt request");
+ if (irq < 0)
return irq;
- }
error = devm_request_threaded_irq(&pdev->dev, irq,
NULL, sensehat_joystick_report,
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-29 5:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-27 0:49 [PATCH -next] Input: Remove unnecessary print function dev_err() Yang Li
2022-06-29 5:51 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.