From: Abel Vesa <abel.vesa@linaro.org>
To: Marek Vasut <marex@denx.de>
Cc: Lucas Stach <l.stach@pengutronix.de>,
linux-clk@vger.kernel.org, Abel Vesa <abel.vesa@nxp.com>,
Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michael Turquette <mturquette@baylibre.com>,
Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH v3 3/6] clk: imx: imx8mp: Add audiomix block control
Date: Wed, 29 Jun 2022 10:41:35 +0300 [thread overview]
Message-ID: <YrwCL2DNUp0mBpEe@linaro.org> (raw)
In-Reply-To: <8d3fcbd9-2fd0-bf90-afa0-a21a79c81dbb@denx.de>
On 22-06-28 19:06:39, Marek Vasut wrote:
> On 6/28/22 09:44, Abel Vesa wrote:
> > On 22-06-27 18:23:33, Marek Vasut wrote:
> > > On 6/27/22 17:35, Abel Vesa wrote:
> > > > On 22-06-25 03:32:32, Marek Vasut wrote:
> > > > > Unlike the other block control IPs in i.MX8M, the audiomix is mostly a
> > > > > series of clock gates and muxes. Model it as a large static table of
> > > > > gates and muxes with one exception, which is the PLL14xx . The PLL14xx
> > > > > SAI PLL has to be registered separately.
> > > > >
> > > >
> > > > Again, there is a chance that the blk-ctrl driver might disable the PD
> > > > from under this.
> > >
> > > Can you elaborate a bit more on this ? How/why do you think so ?
> >
> > At some point, the PDs from the Audiomix IP block will be added to the
> > drivers/soc/imx/imx8mp-blk-ctrl.c. Then, you'll have 2 drivers with the
> > same address range and the imx8mp-blk-ctrl also has runtime PM enabled.
>
> Why would the PDs be added into the block control driver?
>
> The audiomix is purely a clock mux driver, not really a block control driver
> providing PDs of its own.
OK then, fine by me.
WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@linaro.org>
To: Marek Vasut <marex@denx.de>
Cc: Lucas Stach <l.stach@pengutronix.de>,
linux-clk@vger.kernel.org, Abel Vesa <abel.vesa@nxp.com>,
Fabio Estevam <festevam@gmail.com>, Jacky Bai <ping.bai@nxp.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michael Turquette <mturquette@baylibre.com>,
Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com
Subject: Re: [PATCH v3 3/6] clk: imx: imx8mp: Add audiomix block control
Date: Wed, 29 Jun 2022 10:41:35 +0300 [thread overview]
Message-ID: <YrwCL2DNUp0mBpEe@linaro.org> (raw)
In-Reply-To: <8d3fcbd9-2fd0-bf90-afa0-a21a79c81dbb@denx.de>
On 22-06-28 19:06:39, Marek Vasut wrote:
> On 6/28/22 09:44, Abel Vesa wrote:
> > On 22-06-27 18:23:33, Marek Vasut wrote:
> > > On 6/27/22 17:35, Abel Vesa wrote:
> > > > On 22-06-25 03:32:32, Marek Vasut wrote:
> > > > > Unlike the other block control IPs in i.MX8M, the audiomix is mostly a
> > > > > series of clock gates and muxes. Model it as a large static table of
> > > > > gates and muxes with one exception, which is the PLL14xx . The PLL14xx
> > > > > SAI PLL has to be registered separately.
> > > > >
> > > >
> > > > Again, there is a chance that the blk-ctrl driver might disable the PD
> > > > from under this.
> > >
> > > Can you elaborate a bit more on this ? How/why do you think so ?
> >
> > At some point, the PDs from the Audiomix IP block will be added to the
> > drivers/soc/imx/imx8mp-blk-ctrl.c. Then, you'll have 2 drivers with the
> > same address range and the imx8mp-blk-ctrl also has runtime PM enabled.
>
> Why would the PDs be added into the block control driver?
>
> The audiomix is purely a clock mux driver, not really a block control driver
> providing PDs of its own.
OK then, fine by me.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-29 7:41 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 1:32 [PATCH v3 1/6] clk: Introduce devm_clk_hw_register_mux_parent_data() Marek Vasut
2022-06-25 1:32 ` Marek Vasut
2022-06-25 1:32 ` [PATCH v3 2/6] clk: Introduce devm_clk_hw_register_gate_parent_data() Marek Vasut
2022-06-25 1:32 ` Marek Vasut
2022-06-25 1:32 ` [PATCH v3 3/6] clk: imx: imx8mp: Add audiomix block control Marek Vasut
2022-10-10 6:20 ` Shengjiu Wang
2022-06-25 1:32 ` Marek Vasut
2022-06-27 15:35 ` Abel Vesa
2022-06-27 15:35 ` Abel Vesa
2022-06-27 16:23 ` Marek Vasut
2022-06-27 16:23 ` Marek Vasut
2022-06-28 7:44 ` Abel Vesa
2022-06-28 7:44 ` Abel Vesa
2022-06-28 17:06 ` Marek Vasut
2022-06-28 17:06 ` Marek Vasut
2022-06-29 7:41 ` Abel Vesa [this message]
2022-06-29 7:41 ` Abel Vesa
2022-08-04 9:13 ` Peng Fan
2022-08-04 9:13 ` Peng Fan
2022-08-04 9:31 ` Marek Vasut
2022-08-04 9:31 ` Marek Vasut
2022-08-11 14:20 ` Abel Vesa
2022-08-11 14:20 ` Abel Vesa
2022-08-11 14:30 ` Marek Vasut
2022-08-11 14:30 ` Marek Vasut
2022-08-11 15:03 ` Abel Vesa
2022-08-11 15:03 ` Abel Vesa
2022-08-11 15:14 ` Abel Vesa
2022-08-11 15:14 ` Abel Vesa
2022-08-11 16:38 ` Marek Vasut
2022-08-11 16:38 ` Marek Vasut
2022-08-11 16:51 ` Abel Vesa
2022-08-11 16:51 ` Abel Vesa
2022-06-29 7:43 ` Abel Vesa
2022-06-29 7:43 ` Abel Vesa
[not found] ` <CAA+D8ANLrPML3Hp3fYyfiSSUs9V6xAu55d4Y2-8cVVAuTNwaMw@mail.gmail.com>
2022-10-19 14:33 ` Marek Vasut
2022-10-19 14:33 ` Marek Vasut
[not found] ` <CAA+D8ANdOQaz05_SCmTgEW_bCS4ABBLgMzXese_3WWiF8WxzqA@mail.gmail.com>
2022-10-25 21:10 ` Marek Vasut
2022-10-25 21:10 ` Marek Vasut
[not found] ` <CAA+D8AO3KZr9uxS-T1LXK568EeE-wf8yxGCYiayBBxFKDF_HZQ@mail.gmail.com>
2022-10-26 11:03 ` Marek Vasut
2022-10-26 11:03 ` Marek Vasut
2023-02-22 16:58 ` Luca Ceresoli
2023-02-22 16:58 ` Luca Ceresoli
2022-06-25 1:32 ` [PATCH v3 4/6] dt-bindings: clock: " Marek Vasut
2022-06-25 1:32 ` Marek Vasut
2022-06-25 1:32 ` [PATCH v3 5/6] arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX Marek Vasut
2022-06-25 1:32 ` Marek Vasut
2023-02-22 16:59 ` Luca Ceresoli
2023-02-22 16:59 ` Luca Ceresoli
2022-06-25 1:32 ` [PATCH v3 6/6] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK Marek Vasut
2022-06-25 1:32 ` Marek Vasut
2023-02-22 17:22 ` Luca Ceresoli
2023-02-22 17:22 ` Luca Ceresoli
2023-02-22 17:25 ` [PATCH] arm64: dts: imx8mp-msc-sm2s: Add sound card Luca Ceresoli
2023-02-22 17:25 ` Luca Ceresoli
2023-02-22 17:59 ` Marco Felsch
2023-02-22 17:59 ` Marco Felsch
2023-02-22 18:39 ` Marek Vasut
2023-02-22 18:39 ` Marek Vasut
2023-02-22 19:02 ` Marco Felsch
2023-02-22 19:02 ` Marco Felsch
2023-02-23 16:23 ` Marek Vasut
2023-02-23 16:23 ` Marek Vasut
2023-02-24 12:56 ` Marco Felsch
2023-02-24 12:56 ` Marco Felsch
2023-02-22 19:57 ` Luca Ceresoli
2023-02-22 19:57 ` Luca Ceresoli
2023-02-22 18:20 ` Krzysztof Kozlowski
2023-02-22 18:20 ` Krzysztof Kozlowski
2023-02-23 7:30 ` kernel test robot
2023-02-23 7:30 ` kernel test robot
2023-02-23 16:24 ` [PATCH v3 6/6] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK Marek Vasut
2023-02-23 16:24 ` Marek Vasut
2023-02-24 16:16 ` Luca Ceresoli
2023-02-24 16:16 ` Luca Ceresoli
2022-11-21 8:17 ` [PATCH v3 1/6] clk: Introduce devm_clk_hw_register_mux_parent_data() Richard Leitner
2022-11-21 8:17 ` Richard Leitner
2022-11-26 15:23 ` Marek Vasut
2022-11-26 15:23 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrwCL2DNUp0mBpEe@linaro.org \
--to=abel.vesa@linaro.org \
--cc=abel.vesa@nxp.com \
--cc=festevam@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=mturquette@baylibre.com \
--cc=ping.bai@nxp.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.