[PATCH 0/1] drivers: mcb: updates for 5.20

[PATCH 0/1] drivers: mcb: updates for 5.20

[Johannes Thumshirn]

Hi Greg,

Here's one patch for drivers/mcb aimed at 5.20. It's a simple change from
ida_simple_get()/ida_simple_remove() to ida_alloc() and ida_free() from keliu.

Thanks,
	Johannes


keliu (1):
  drivers: mcb: directly use ida_alloc()/free()

 drivers/mcb/mcb-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.35.3

[PATCH 1/1] drivers: mcb: directly use ida_alloc()/free()

[Johannes Thumshirn]

From: keliu <liuke94@huawei.com>

Use ida_alloc()/ida_free() instead of deprecated
ida_simple_get()/ida_simple_remove() .

Signed-off-by: keliu <liuke94@huawei.com>
Signed-off-by: Johannes Thumshirn <jth@kernel.org>
---
 drivers/mcb/mcb-core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mcb/mcb-core.c b/drivers/mcb/mcb-core.c
index cf128b3471d7..338fc889b357 100644
--- a/drivers/mcb/mcb-core.c
+++ b/drivers/mcb/mcb-core.c
@@ -254,7 +254,7 @@ static void mcb_free_bus(struct device *dev)
 	struct mcb_bus *bus = to_mcb_bus(dev);
 
 	put_device(bus->carrier);
-	ida_simple_remove(&mcb_ida, bus->bus_nr);
+	ida_free(&mcb_ida, bus->bus_nr);
 	kfree(bus);
 }
 
@@ -273,7 +273,7 @@ struct mcb_bus *mcb_alloc_bus(struct device *carrier)
 	if (!bus)
 		return ERR_PTR(-ENOMEM);
 
-	bus_nr = ida_simple_get(&mcb_ida, 0, 0, GFP_KERNEL);
+	bus_nr = ida_alloc(&mcb_ida, GFP_KERNEL);
 	if (bus_nr < 0) {
 		kfree(bus);
 		return ERR_PTR(bus_nr);
-- 
2.35.3

Re: [PATCH 0/1] drivers: mcb: updates for 5.20

[Greg Kroah-Hartmann]

On Mon, Jul 11, 2022 at 11:50:07PM -0700, Johannes Thumshirn wrote:
> Hi Greg,
> 
> Here's one patch for drivers/mcb aimed at 5.20. It's a simple change from
> ida_simple_get()/ida_simple_remove() to ida_alloc() and ida_free() from keliu.

I'll take this, but you need to fix up your email infrastructure, it is
sending out bad DKIM signatures, which do not make me the most
comfortable taking, as anyone could be spoofing your address:

Looking up https://lore.kernel.org/r/480676bee970da16bf1fa8565277240014395ba3.1657607743.git.johannes.thumshirn%40wdc.com
Grabbing thread from lore.kernel.org/all/480676bee970da16bf1fa8565277240014395ba3.1657607743.git.johannes.thumshirn%40wdc.com/t.mbox.gz
Analyzing 2 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✗ [PATCH 1/1] drivers: mcb: directly use ida_alloc()/free()
  ---
  ✗ BADSIG: DKIM/wdc.com
---
Total patches: 1
---

Can you please work with your email admins to fix this up?

thanks,

greg k-h

Re: [PATCH 0/1] drivers: mcb: updates for 5.20

[Johannes Thumshirn]

On 12.07.22 09:06, Greg Kroah-Hartmann wrote:
> On Mon, Jul 11, 2022 at 11:50:07PM -0700, Johannes Thumshirn wrote:
>> Hi Greg,
>>
>> Here's one patch for drivers/mcb aimed at 5.20. It's a simple change from
>> ida_simple_get()/ida_simple_remove() to ida_alloc() and ida_free() from keliu.
> 
> I'll take this, but you need to fix up your email infrastructure, it is
> sending out bad DKIM signatures, which do not make me the most
> comfortable taking, as anyone could be spoofing your address:
> 
> Looking up https://lore.kernel.org/r/480676bee970da16bf1fa8565277240014395ba3.1657607743.git.johannes.thumshirn%40wdc.com
> Grabbing thread from lore.kernel.org/all/480676bee970da16bf1fa8565277240014395ba3.1657607743.git.johannes.thumshirn%40wdc.com/t.mbox.gz
> Analyzing 2 messages in the thread
> Checking attestation on all messages, may take a moment...
> ---
>   ✗ [PATCH 1/1] drivers: mcb: directly use ida_alloc()/free()
>   ---
>   ✗ BADSIG: DKIM/wdc.com
> ---
> Total patches: 1
> ---
> 
> Can you please work with your email admins to fix this up?

Thanks, not again. I'll work with out IT to get this fixed.