All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
	Oleksij Rempel <linux@rempel-privat.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] i2c: imx: Retry transfer on transient failure
Date: Tue, 12 Jul 2022 13:32:19 +0200	[thread overview]
Message-ID: <Ys1bw9zuIwWS+bqw@shikoro> (raw)
In-Reply-To: <20220712084716.bw626gt7cwcjt3wq@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]


> > +#define I2C_IMX_MAX_RETRIES 3     /* Retries on arbitration loss */
> 
> Just one question: Why 3 and should we document this within the commit
> message?

Note that you can always change this from userspace via i2c-dev and the
I2C_RETRIES ioctl. So, it is really about a default value here.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
	Oleksij Rempel <linux@rempel-privat.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] i2c: imx: Retry transfer on transient failure
Date: Tue, 12 Jul 2022 13:32:19 +0200	[thread overview]
Message-ID: <Ys1bw9zuIwWS+bqw@shikoro> (raw)
In-Reply-To: <20220712084716.bw626gt7cwcjt3wq@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 308 bytes --]


> > +#define I2C_IMX_MAX_RETRIES 3     /* Retries on arbitration loss */
> 
> Just one question: Why 3 and should we document this within the commit
> message?

Note that you can always change this from userspace via i2c-dev and the
I2C_RETRIES ioctl. So, it is really about a default value here.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-07-12 11:32 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12  8:24 [PATCH v1] i2c: imx: Retry transfer on transient failure Francesco Dolcini
2022-07-12  8:24 ` Francesco Dolcini
2022-07-12  8:47 ` Marco Felsch
2022-07-12  8:47   ` Marco Felsch
2022-07-12  9:14   ` Francesco Dolcini
2022-07-12  9:14     ` Francesco Dolcini
2022-07-12 11:32   ` Wolfram Sang [this message]
2022-07-12 11:32     ` Wolfram Sang
2022-07-12 12:02     ` Marco Felsch
2022-07-12 12:02       ` Marco Felsch
2022-07-12  9:05 ` Uwe Kleine-König
2022-07-12  9:05   ` Uwe Kleine-König
2022-07-12 10:05   ` Francesco Dolcini
2022-07-12 10:05     ` Francesco Dolcini
2022-07-13 11:57     ` Francesco Dolcini
2022-07-13 11:57       ` Francesco Dolcini
2022-07-13 13:24       ` Oleksij Rempel
2022-07-13 13:24         ` Oleksij Rempel
2022-07-13 13:43         ` Francesco Dolcini
2022-07-13 13:43           ` Francesco Dolcini
2022-07-13 15:57           ` Oleksij Rempel
2022-07-13 15:57             ` Oleksij Rempel
2022-07-13 20:25             ` Francesco Dolcini
2022-07-13 20:25               ` Francesco Dolcini
2022-07-14  7:07               ` Oleksij Rempel
2022-07-14  7:07                 ` Oleksij Rempel
2022-07-14  7:34                 ` Francesco Dolcini
2022-07-14  7:34                   ` Francesco Dolcini
2022-07-15  6:49                   ` Uwe Kleine-König
2022-07-15  6:49                     ` Uwe Kleine-König
2022-07-15  7:24                     ` Francesco Dolcini
2022-07-15  7:24                       ` Francesco Dolcini
2022-07-15  8:34                       ` Uwe Kleine-König
2022-07-15  8:34                         ` Uwe Kleine-König
2022-07-15 11:45                         ` Francesco Dolcini
2022-07-15 11:45                           ` Francesco Dolcini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ys1bw9zuIwWS+bqw@shikoro \
    --to=wsa@kernel.org \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux@rempel-privat.de \
    --cc=m.felsch@pengutronix.de \
    --cc=oleksandr.suvorov@toradex.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.