Re: [PATCH 4.14 1/4] can: kvaser_usb: Add struct kvaser_usb_dev_cfg

[Greg KH <gregkh@linuxfoundation.org>]

On Sun, Jul 10, 2022 at 08:40:30PM +0200, Jimmy Assarsson wrote:
> On 7/10/22 16:21, Greg KH wrote:
> > On Fri, Jul 08, 2022 at 08:46:50PM +0200, Jimmy Assarsson wrote:
> > > Add struct kvaser_usb_dev_cfg to ease backporting of upstream commits:
> > > 49f274c72357 (can: kvaser_usb: replace run-time checks with struct kvaser_usb_driver_info)
> > > e6c80e601053 (can: kvaser_usb: kvaser_usb_leaf: fix CAN clock frequency regression)
> > > b3b6df2c56d8 (can: kvaser_usb: kvaser_usb_leaf: fix bittiming limits)
> > 
> > What upstream commit is this from?
> 
> Hi Greg,
> 
> The original upstream commit introducing struct kvaser_usb_dev_cfg is
> 7259124eac7d1b76b41c7a9cb2511a30556deebe
> can: kvaser_usb: Split driver into kvaser_usb_core.c and kvaser_usb_leaf.c
> And was first merged to 4.19.
> 
> This was part of a major restructure of the driver to add support for new type of devices.

Then why not just take thos commits, _OR_ rework the bugfixes to handle
the old style of drivers?

Doing this type of major change that is not directly upstream is almost
always a big mistake as it's not tested well and diverges from what is
in Linus's tree.

Please try to rework these two series and resubmit.

thanks,

greg k-h