From: Greg KH <gregkh@linuxfoundation.org>
To: Jimmy Assarsson <extja@kvaser.com>
Cc: stable@vger.kernel.org, linux-can@vger.kernel.org,
Marc Kleine-Budde <mkl@pengutronix.de>,
Jimmy Assarsson <jimmyassarsson@gmail.com>
Subject: Re: [PATCH 4.14 1/4] can: kvaser_usb: Add struct kvaser_usb_dev_cfg
Date: Sun, 10 Jul 2022 16:21:34 +0200 [thread overview]
Message-ID: <YsrgbqIFfcxXesWw@kroah.com> (raw)
In-Reply-To: <20220708184653.280882-2-extja@kvaser.com>
On Fri, Jul 08, 2022 at 08:46:50PM +0200, Jimmy Assarsson wrote:
> Add struct kvaser_usb_dev_cfg to ease backporting of upstream commits:
> 49f274c72357 (can: kvaser_usb: replace run-time checks with struct kvaser_usb_driver_info)
> e6c80e601053 (can: kvaser_usb: kvaser_usb_leaf: fix CAN clock frequency regression)
> b3b6df2c56d8 (can: kvaser_usb: kvaser_usb_leaf: fix bittiming limits)
What upstream commit is this from?
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Jimmy Assarsson <extja@kvaser.com>
> ---
> drivers/net/can/usb/kvaser_usb.c | 76 ++++++++++++++++++++++----------
> 1 file changed, 52 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c
> index 9742e32d5cd5..6759868924b2 100644
> --- a/drivers/net/can/usb/kvaser_usb.c
> +++ b/drivers/net/can/usb/kvaser_usb.c
> @@ -31,10 +31,6 @@
> #define USB_SEND_TIMEOUT 1000 /* msecs */
> #define USB_RECV_TIMEOUT 1000 /* msecs */
> #define RX_BUFFER_SIZE 3072
> -#define KVASER_USB_CAN_CLOCK_8MHZ 8000000
> -#define KVASER_USB_CAN_CLOCK_16MHZ 16000000
> -#define KVASER_USB_CAN_CLOCK_24MHZ 24000000
> -#define KVASER_USB_CAN_CLOCK_32MHZ 32000000
You also deleted these, you didn't really describe any of this in the
changelog text at all :(
Why not just backport the needed commit instead of this unknown one?
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-10 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 18:46 [PATCH 4.14 0/4] can: kvaser_usb: CAN clock frequency regression Jimmy Assarsson
2022-07-08 18:46 ` [PATCH 4.14 1/4] can: kvaser_usb: Add struct kvaser_usb_dev_cfg Jimmy Assarsson
2022-07-10 14:21 ` Greg KH [this message]
2022-07-10 18:40 ` Jimmy Assarsson
2022-07-12 19:18 ` Greg KH
2022-07-08 18:46 ` [PATCH 4.14 2/4] can: kvaser_usb: replace run-time checks with struct kvaser_usb_driver_info Jimmy Assarsson
2022-07-08 18:46 ` [PATCH 4.14 3/4] can: kvaser_usb: fix CAN clock frequency regression Jimmy Assarsson
2022-07-08 18:46 ` [PATCH 4.14 4/4] can: kvaser_usb: fix bittiming limits Jimmy Assarsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsrgbqIFfcxXesWw@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=extja@kvaser.com \
--cc=jimmyassarsson@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.