From: Andrew Lunn <andrew@lunn.ch>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Wei Fang <wei.fang@nxp.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, aisheng.dong@nxp.com,
devicetree@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, sudeep.holla@arm.com,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support
Date: Mon, 4 Jul 2022 10:12:48 +0200 [thread overview]
Message-ID: <YsKhAFkd0HCZVVvH@lunn.ch> (raw)
In-Reply-To: <751e1ec6-2d34-44f6-a6c3-775df8a3cea2@pengutronix.de>
> > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>,
> > + <&pcc4 IMX8ULP_CLK_ENET>,
> > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>,
> > + <&clock_ext_rmii>;
> > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
>
> I think the default should be the other way round, assume MAC to provide reference
> clock and allow override on board-level if PHY does it instead.
I would make it the same as all the other instances of FEC in the
IMX7, IMX6, IMX5, IMX4, Vybrid etc
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Wei Fang <wei.fang@nxp.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, aisheng.dong@nxp.com,
devicetree@vger.kernel.org, peng.fan@nxp.com, ping.bai@nxp.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, sudeep.holla@arm.com,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support
Date: Mon, 4 Jul 2022 10:12:48 +0200 [thread overview]
Message-ID: <YsKhAFkd0HCZVVvH@lunn.ch> (raw)
In-Reply-To: <751e1ec6-2d34-44f6-a6c3-775df8a3cea2@pengutronix.de>
> > + clocks = <&cgc1 IMX8ULP_CLK_XBAR_DIVBUS>,
> > + <&pcc4 IMX8ULP_CLK_ENET>,
> > + <&cgc1 IMX8ULP_CLK_ENET_TS_SEL>,
> > + <&clock_ext_rmii>;
> > + clock-names = "ipg", "ahb", "ptp", "enet_clk_ref";
>
> I think the default should be the other way round, assume MAC to provide reference
> clock and allow override on board-level if PHY does it instead.
I would make it the same as all the other instances of FEC in the
IMX7, IMX6, IMX5, IMX4, Vybrid etc
Andrew
next prev parent reply other threads:[~2022-07-04 8:16 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 10:10 [PATCH 0/3] Add the fec node on i.MX8ULP platform Wei Fang
2022-07-04 10:10 ` Wei Fang
2022-07-04 10:10 ` [PATCH 1/3] dt-bings: net: fsl,fec: update compatible item Wei Fang
2022-07-04 10:10 ` Wei Fang
2022-07-04 9:12 ` Krzysztof Kozlowski
2022-07-04 9:12 ` Krzysztof Kozlowski
2022-07-05 2:47 ` [EXT] " Wei Fang
2022-07-05 2:47 ` Wei Fang
2022-07-05 7:27 ` Krzysztof Kozlowski
2022-07-05 7:27 ` Krzysztof Kozlowski
2022-07-05 7:32 ` Wei Fang
2022-07-05 7:32 ` Wei Fang
2022-08-18 1:33 ` Shawn Guo
2022-08-18 1:33 ` Shawn Guo
2022-08-18 7:51 ` Krzysztof Kozlowski
2022-08-18 7:51 ` Krzysztof Kozlowski
2022-08-18 9:22 ` Shawn Guo
2022-08-18 9:22 ` Shawn Guo
2022-08-18 9:46 ` Krzysztof Kozlowski
2022-08-18 9:46 ` Krzysztof Kozlowski
2022-08-18 13:57 ` Shawn Guo
2022-08-18 13:57 ` Shawn Guo
2022-08-18 14:04 ` Krzysztof Kozlowski
2022-08-18 14:04 ` Krzysztof Kozlowski
2022-08-19 1:50 ` Wei Fang
2022-08-19 1:50 ` Wei Fang
2022-08-19 3:13 ` Peng Fan
2022-08-19 3:13 ` Peng Fan
2022-08-19 6:31 ` Krzysztof Kozlowski
2022-08-19 6:31 ` Krzysztof Kozlowski
2022-08-19 7:02 ` Wei Fang
2022-08-19 7:02 ` Wei Fang
2022-07-04 10:10 ` [PATCH 2/3] arm64: dts: imx8ulp: Add the fec support Wei Fang
2022-07-04 10:10 ` Wei Fang
2022-07-04 7:07 ` Ahmad Fatoum
2022-07-04 7:07 ` Ahmad Fatoum
2022-07-04 8:12 ` Andrew Lunn [this message]
2022-07-04 8:12 ` Andrew Lunn
2022-07-05 2:45 ` [EXT] " Wei Fang
2022-07-05 2:45 ` Wei Fang
2022-07-04 10:10 ` [PATCH 3/3] arm64: dts: imx8ulp-evk: " Wei Fang
2022-07-04 10:10 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsKhAFkd0HCZVVvH@lunn.ch \
--to=andrew@lunn.ch \
--cc=a.fatoum@pengutronix.de \
--cc=aisheng.dong@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.