From: Thierry Reding <thierry.reding@gmail.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: mperttunen@nvidia.com, iommu@lists.linux.dev,
linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH] gpu: host1x: Register context bus unconditionally
Date: Fri, 8 Jul 2022 17:11:57 +0200 [thread overview]
Message-ID: <YshJPZMMlZVl5i51@orome> (raw)
In-Reply-To: <70cb6f20-7028-9cf8-6b3a-a074c0047687@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]
On Fri, Jul 08, 2022 at 03:44:09PM +0100, Robin Murphy wrote:
> On 2022-07-08 15:32, Thierry Reding wrote:
> > On Thu, Jul 07, 2022 at 06:30:44PM +0100, Robin Murphy wrote:
> > > Conditional registration is a problem for other subsystems which may
> > > unwittingly try to interact with host1x_context_device_bus_type in an
> > > uninitialised state on non-Tegra platforms. A look under /sys/bus on a
> > > typical system already reveals plenty of entries from enabled but
> > > otherwise irrelevant configs, so lets keep things simple and register
> > > our context bus unconditionally too.
> > >
> > > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> > > ---
> > > drivers/gpu/host1x/context_bus.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> >
> > Applied, thanks.
> >
> > Do we need this in v5.19 or is it enough if this gets into v5.20?
>
> It's not strictly a critical fix, so I think 5.20 is fine. I plan to post v4
> of my bus_set_iommu() series next week as the hopefully-final version, but
> at this point I think it might be safer to hold off actually merging that
> until early next cycle, to give it plenty of time in -next.
Alright, I'll send it for v5.20 for now. If things change we can always
backport to v5.19.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: linux-tegra@vger.kernel.org, iommu@lists.linux.dev,
Joerg Roedel <joro@8bytes.org>,
dri-devel@lists.freedesktop.org, mperttunen@nvidia.com
Subject: Re: [PATCH] gpu: host1x: Register context bus unconditionally
Date: Fri, 8 Jul 2022 17:11:57 +0200 [thread overview]
Message-ID: <YshJPZMMlZVl5i51@orome> (raw)
In-Reply-To: <70cb6f20-7028-9cf8-6b3a-a074c0047687@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]
On Fri, Jul 08, 2022 at 03:44:09PM +0100, Robin Murphy wrote:
> On 2022-07-08 15:32, Thierry Reding wrote:
> > On Thu, Jul 07, 2022 at 06:30:44PM +0100, Robin Murphy wrote:
> > > Conditional registration is a problem for other subsystems which may
> > > unwittingly try to interact with host1x_context_device_bus_type in an
> > > uninitialised state on non-Tegra platforms. A look under /sys/bus on a
> > > typical system already reveals plenty of entries from enabled but
> > > otherwise irrelevant configs, so lets keep things simple and register
> > > our context bus unconditionally too.
> > >
> > > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> > > ---
> > > drivers/gpu/host1x/context_bus.c | 5 -----
> > > 1 file changed, 5 deletions(-)
> >
> > Applied, thanks.
> >
> > Do we need this in v5.19 or is it enough if this gets into v5.20?
>
> It's not strictly a critical fix, so I think 5.20 is fine. I plan to post v4
> of my bus_set_iommu() series next week as the hopefully-final version, but
> at this point I think it might be safer to hold off actually merging that
> until early next cycle, to give it plenty of time in -next.
Alright, I'll send it for v5.20 for now. If things change we can always
backport to v5.19.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-08 15:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 17:30 [PATCH] gpu: host1x: Register context bus unconditionally Robin Murphy
2022-07-07 17:30 ` Robin Murphy
2022-07-08 8:33 ` Mikko Perttunen
2022-07-08 8:33 ` Mikko Perttunen
2022-07-08 14:32 ` Thierry Reding
2022-07-08 14:32 ` Thierry Reding
2022-07-08 14:44 ` Robin Murphy
2022-07-08 14:44 ` Robin Murphy
2022-07-08 15:11 ` Thierry Reding [this message]
2022-07-08 15:11 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YshJPZMMlZVl5i51@orome \
--to=thierry.reding@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.