* [PATCH] iio: adc: ad7949: Fix error message
@ 2022-07-08 20:17 Thorsten Scherer
2022-07-08 22:51 ` Liam Beguin
0 siblings, 1 reply; 4+ messages in thread
From: Thorsten Scherer @ 2022-07-08 20:17 UTC (permalink / raw)
To: jic23, linux-iio; +Cc: Thorsten Scherer
Signed-off-by: Thorsten Scherer <t.scherer@eckelmann.de>
---
drivers/iio/adc/ad7949.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c
index 44bb5fde83de..12fb5f9971db 100644
--- a/drivers/iio/adc/ad7949.c
+++ b/drivers/iio/adc/ad7949.c
@@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)
ret = ad7949_spi_init(ad7949_adc);
if (ret) {
- dev_err(dev, "enable to init this device: %d\n", ret);
+ dev_err(dev, "fail to init this device: %d\n", ret);
return ret;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: ad7949: Fix error message
2022-07-08 20:17 [PATCH] iio: adc: ad7949: Fix error message Thorsten Scherer
@ 2022-07-08 22:51 ` Liam Beguin
2022-07-09 5:38 ` Thorsten Scherer
0 siblings, 1 reply; 4+ messages in thread
From: Liam Beguin @ 2022-07-08 22:51 UTC (permalink / raw)
To: Thorsten Scherer; +Cc: jic23, linux-iio
On Fri, Jul 08, 2022 at 10:17:20PM +0200, Thorsten Scherer wrote:
> Signed-off-by: Thorsten Scherer <t.scherer@eckelmann.de>
> ---
> drivers/iio/adc/ad7949.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c
> index 44bb5fde83de..12fb5f9971db 100644
> --- a/drivers/iio/adc/ad7949.c
> +++ b/drivers/iio/adc/ad7949.c
> @@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)
>
> ret = ad7949_spi_init(ad7949_adc);
> if (ret) {
> - dev_err(dev, "enable to init this device: %d\n", ret);
> + dev_err(dev, "fail to init this device: %d\n", ret);
Maybe 'failed' or 'unable' instead of 'fail'?
otherwise:
Reviewed-by: Liam Beguin <liambeguin@gmail.com>
Cheers,
Liam
> return ret;
> }
>
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: ad7949: Fix error message
2022-07-08 22:51 ` Liam Beguin
@ 2022-07-09 5:38 ` Thorsten Scherer
2022-07-16 17:51 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Thorsten Scherer @ 2022-07-09 5:38 UTC (permalink / raw)
To: Liam Beguin; +Cc: jic23, linux-iio
Hi,
On Fri, Jul 08, 2022 at 06:51:26PM -0400, Liam Beguin wrote:
> On Fri, Jul 08, 2022 at 10:17:20PM +0200, Thorsten Scherer wrote:
> > Signed-off-by: Thorsten Scherer <t.scherer@eckelmann.de>
> > ---
> > drivers/iio/adc/ad7949.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c
> > index 44bb5fde83de..12fb5f9971db 100644
> > --- a/drivers/iio/adc/ad7949.c
> > +++ b/drivers/iio/adc/ad7949.c
> > @@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)
> >
> > ret = ad7949_spi_init(ad7949_adc);
> > if (ret) {
> > - dev_err(dev, "enable to init this device: %d\n", ret);
> > + dev_err(dev, "fail to init this device: %d\n", ret);
>
> Maybe 'failed' or 'unable' instead of 'fail'?
I decided to be consistent with the wording of the other dev_err's. If
anyone cares, I'll send a v2 adjusting the others as well.
> otherwise:
>
> Reviewed-by: Liam Beguin <liambeguin@gmail.com>
>
> Cheers,
> Liam
>
Best regards
Thorsten
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: adc: ad7949: Fix error message
2022-07-09 5:38 ` Thorsten Scherer
@ 2022-07-16 17:51 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2022-07-16 17:51 UTC (permalink / raw)
To: Thorsten Scherer; +Cc: Liam Beguin, linux-iio
On Sat, 9 Jul 2022 07:38:10 +0200
Thorsten Scherer <t.scherer@eckelmann.de> wrote:
> Hi,
>
> On Fri, Jul 08, 2022 at 06:51:26PM -0400, Liam Beguin wrote:
> > On Fri, Jul 08, 2022 at 10:17:20PM +0200, Thorsten Scherer wrote:
> > > Signed-off-by: Thorsten Scherer <t.scherer@eckelmann.de>
> > > ---
> > > drivers/iio/adc/ad7949.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c
> > > index 44bb5fde83de..12fb5f9971db 100644
> > > --- a/drivers/iio/adc/ad7949.c
> > > +++ b/drivers/iio/adc/ad7949.c
> > > @@ -400,7 +400,7 @@ static int ad7949_spi_probe(struct spi_device *spi)
> > >
> > > ret = ad7949_spi_init(ad7949_adc);
> > > if (ret) {
> > > - dev_err(dev, "enable to init this device: %d\n", ret);
> > > + dev_err(dev, "fail to init this device: %d\n", ret);
> >
> > Maybe 'failed' or 'unable' instead of 'fail'?
>
> I decided to be consistent with the wording of the other dev_err's. If
> anyone cares, I'll send a v2 adjusting the others as well.
I've taken the view that this is obviously an improvement so applied
it to the togreg branch of iio.git (note given timing this will only be
pushed out for now as testing, and later rebased on rc1).
If anyone wants to follow up with a grammar improvement patch, that's
fine with me, but the meaning is clear enough either way in my view.
Jonathan
>
> > otherwise:
> >
> > Reviewed-by: Liam Beguin <liambeguin@gmail.com>
> >
> > Cheers,
> > Liam
> >
>
> Best regards
> Thorsten
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-16 17:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-08 20:17 [PATCH] iio: adc: ad7949: Fix error message Thorsten Scherer
2022-07-08 22:51 ` Liam Beguin
2022-07-09 5:38 ` Thorsten Scherer
2022-07-16 17:51 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.