From: Eric Biggers <ebiggers@kernel.org>
To: "Guozihua (Scott)" <guozihua@huawei.com>
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
zengxianjun3@huawei.com, yunjia.wang@huawei.com
Subject: Re: An inquire about a read out-of-bound found in poly1305-neon
Date: Mon, 11 Jul 2022 17:58:09 +0000 [thread overview]
Message-ID: <YsxksSnCsk3TQVD+@gmail.com> (raw)
In-Reply-To: <65952163-6b78-a02a-ba14-933807d3cfec@huawei.com>
On Mon, Jul 11, 2022 at 09:34:49PM +0800, Guozihua (Scott) wrote:
> Directly calling poly1305_init_arm64 instead of poly1305_init_arch() is also
> tried but it would fail the self-test as well.
I think that's the correct fix. Are you sure it fails the self-test? It should
look like:
poly1305_init_arm64(&dctx->h, src);
Just like the arm32 version in arch/arm/crypto/poly1305-glue.c. Note that
&dctx->h must be used rather than just dctx.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: "Guozihua (Scott)" <guozihua@huawei.com>
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
herbert@gondor.apana.org.au, davem@davemloft.net,
zengxianjun3@huawei.com, yunjia.wang@huawei.com
Subject: Re: An inquire about a read out-of-bound found in poly1305-neon
Date: Mon, 11 Jul 2022 17:58:09 +0000 [thread overview]
Message-ID: <YsxksSnCsk3TQVD+@gmail.com> (raw)
In-Reply-To: <65952163-6b78-a02a-ba14-933807d3cfec@huawei.com>
On Mon, Jul 11, 2022 at 09:34:49PM +0800, Guozihua (Scott) wrote:
> Directly calling poly1305_init_arm64 instead of poly1305_init_arch() is also
> tried but it would fail the self-test as well.
I think that's the correct fix. Are you sure it fails the self-test? It should
look like:
poly1305_init_arm64(&dctx->h, src);
Just like the arm32 version in arch/arm/crypto/poly1305-glue.c. Note that
&dctx->h must be used rather than just dctx.
- Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-11 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 13:34 An inquire about a read out-of-bound found in poly1305-neon Guozihua (Scott)
2022-07-11 13:34 ` Guozihua (Scott)
2022-07-11 17:58 ` Eric Biggers [this message]
2022-07-11 17:58 ` Eric Biggers
2022-07-12 1:57 ` Guozihua (Scott)
2022-07-12 1:57 ` Guozihua (Scott)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsxksSnCsk3TQVD+@gmail.com \
--to=ebiggers@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=guozihua@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=yunjia.wang@huawei.com \
--cc=zengxianjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.