All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Li Huafei <lihuafei1@huawei.com>
Cc: ardb@kernel.org, will@kernel.org, mark.rutland@arm.com,
	broonie@kernel.org, peterz@infradead.org, mingo@redhat.com,
	acme@kernel.org, alexander.shishkin@linux.intel.com,
	jolsa@kernel.org, namhyung@kernel.org, arnd@arndb.de,
	linus.walleij@linaro.org, rostedt@goodmis.org,
	nick.hawkins@hpe.com, john@phrozen.org, mhiramat@kernel.org,
	ast@kernel.org, linyujun809@huawei.com, ndesaulniers@google.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: stacktrace: Avoid duplicate saving of exception PC value
Date: Tue, 26 Jul 2022 11:22:35 +0100	[thread overview]
Message-ID: <Yt/AawOdA8w24toW@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220712021527.109921-3-lihuafei1@huawei.com>

On Tue, Jul 12, 2022 at 10:15:24AM +0800, Li Huafei wrote:
> @@ -34,6 +37,9 @@ void arm_get_current_stackframe(struct pt_regs *regs, struct stackframe *frame)
>  		frame->kr_cur = NULL;
>  		frame->tsk = current;
>  #endif
> +#ifdef CONFIG_UNWINDER_FRAME_POINTER
> +		frame->ex_frame = in_entry_text(frame->pc) ? true : false;

in_entry_text() returns a bool, so there's no need for the ternary
operator. The same comment applies throughout this patch.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Li Huafei <lihuafei1@huawei.com>
Cc: ardb@kernel.org, will@kernel.org, mark.rutland@arm.com,
	broonie@kernel.org, peterz@infradead.org, mingo@redhat.com,
	acme@kernel.org, alexander.shishkin@linux.intel.com,
	jolsa@kernel.org, namhyung@kernel.org, arnd@arndb.de,
	linus.walleij@linaro.org, rostedt@goodmis.org,
	nick.hawkins@hpe.com, john@phrozen.org, mhiramat@kernel.org,
	ast@kernel.org, linyujun809@huawei.com, ndesaulniers@google.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: stacktrace: Avoid duplicate saving of exception PC value
Date: Tue, 26 Jul 2022 11:22:35 +0100	[thread overview]
Message-ID: <Yt/AawOdA8w24toW@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220712021527.109921-3-lihuafei1@huawei.com>

On Tue, Jul 12, 2022 at 10:15:24AM +0800, Li Huafei wrote:
> @@ -34,6 +37,9 @@ void arm_get_current_stackframe(struct pt_regs *regs, struct stackframe *frame)
>  		frame->kr_cur = NULL;
>  		frame->tsk = current;
>  #endif
> +#ifdef CONFIG_UNWINDER_FRAME_POINTER
> +		frame->ex_frame = in_entry_text(frame->pc) ? true : false;

in_entry_text() returns a bool, so there's no need for the ternary
operator. The same comment applies throughout this patch.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-07-26 10:23 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12  2:15 [PATCH 0/5] ARM: Convert to ARCH_STACKWALK Li Huafei
2022-07-12  2:15 ` Li Huafei
2022-07-12  2:15 ` [PATCH 1/5] ARM: stacktrace: Skip frame pointer boundary check for call_with_stack() Li Huafei
2022-07-12  2:15   ` Li Huafei
2022-07-18  8:57   ` Linus Walleij
2022-07-18  8:57     ` Linus Walleij
2022-07-26  8:10     ` Li Huafei
2022-07-26  8:10       ` Li Huafei
2022-07-12  2:15 ` [PATCH 2/5] ARM: stacktrace: Avoid duplicate saving of exception PC value Li Huafei
2022-07-12  2:15   ` Li Huafei
2022-07-18  9:01   ` Linus Walleij
2022-07-18  9:01     ` Linus Walleij
2022-07-26  9:10     ` Li Huafei
2022-07-26  9:10       ` Li Huafei
2022-07-26 10:22   ` Russell King (Oracle) [this message]
2022-07-26 10:22     ` Russell King (Oracle)
2022-07-26 12:21     ` Li Huafei
2022-07-26 12:21       ` Li Huafei
2022-07-12  2:15 ` [PATCH 3/5] ARM: stacktrace: Allow stack trace saving for non-current tasks Li Huafei
2022-07-12  2:15   ` Li Huafei
2022-07-18  9:07   ` Linus Walleij
2022-07-18  9:07     ` Linus Walleij
2022-07-26  9:12     ` Li Huafei
2022-07-26  9:12       ` Li Huafei
2022-07-26  9:49       ` Russell King (Oracle)
2022-07-26  9:49         ` Russell King (Oracle)
2022-07-26 12:08         ` Li Huafei
2022-07-26 12:08           ` Li Huafei
2022-07-12  2:15 ` [PATCH 4/5] ARM: stacktrace: Make stack walk callback consistent with generic code Li Huafei
2022-07-12  2:15   ` Li Huafei
2022-07-12 13:34   ` Mark Brown
2022-07-12 13:34     ` Mark Brown
2022-07-13 11:21     ` Li Huafei
2022-07-13 11:21       ` Li Huafei
2022-07-18  9:09   ` Linus Walleij
2022-07-18  9:09     ` Linus Walleij
2022-07-26  9:19     ` Li Huafei
2022-07-26  9:19       ` Li Huafei
2022-07-12  2:15 ` [PATCH 5/5] ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK Li Huafei
2022-07-12  2:15   ` Li Huafei
2022-07-18  9:12   ` Linus Walleij
2022-07-18  9:12     ` Linus Walleij
2022-07-26  9:15     ` Li Huafei
2022-07-26  9:15       ` Li Huafei
2022-07-27  6:29     ` Li Huafei
2022-07-27  6:29       ` Li Huafei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yt/AawOdA8w24toW@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=ast@kernel.org \
    --cc=broonie@kernel.org \
    --cc=john@phrozen.org \
    --cc=jolsa@kernel.org \
    --cc=lihuafei1@huawei.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linyujun809@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nick.hawkins@hpe.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.