From: Huang Rui <ray.huang@amd.com>
To: "Liu, Aaron" <Aaron.Liu@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: add declaration of function ‘drm_need_swiotlb’ in gmc10.0
Date: Mon, 25 Jul 2022 09:37:46 +0800 [thread overview]
Message-ID: <Yt3z6h4LsRJF6T2M@amd.com> (raw)
In-Reply-To: <20220725013027.1423657-1-aaron.liu@amd.com>
On Mon, Jul 25, 2022 at 09:30:27AM +0800, Liu, Aaron wrote:
> Fixing compiling error:
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c: In function ‘gmc_v10_0_sw_init’:
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:983:23: error: implicit declaration of function ‘drm_need_swiotlb’ [-Werror=implicit-function-declaration]
> 983 | adev->need_swiotlb = drm_need_swiotlb(44);
>
> Signed-off-by: Aaron Liu <aaron.liu@amd.com>
Please revert the one in the amd-staging-drm-next, and squeeze it into the
last one. We would better not separate them as two.
Please make sure the patch can be built successfully at least before push
it.
Thanks,
Ray
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index f8fa27b7b53b..9ae8cdaa033e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -22,6 +22,9 @@
> */
> #include <linux/firmware.h>
> #include <linux/pci.h>
> +
> +#include <drm/drm_cache.h>
> +
> #include "amdgpu.h"
> #include "amdgpu_atomfirmware.h"
> #include "gmc_v10_0.h"
> --
> 2.37.0
>
prev parent reply other threads:[~2022-07-25 1:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 1:30 [PATCH] drm/amdgpu: add declaration of function ‘drm_need_swiotlb’ in gmc10.0 Aaron Liu
2022-07-25 1:37 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt3z6h4LsRJF6T2M@amd.com \
--to=ray.huang@amd.com \
--cc=Aaron.Liu@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.