* [PATCH] drm/amdgpu: add declaration of function ‘drm_need_swiotlb’ in gmc10.0
@ 2022-07-25 1:30 Aaron Liu
2022-07-25 1:37 ` Huang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Liu @ 2022-07-25 1:30 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Ray.Huang, Aaron Liu
Fixing compiling error:
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c: In function ‘gmc_v10_0_sw_init’:
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:983:23: error: implicit declaration of function ‘drm_need_swiotlb’ [-Werror=implicit-function-declaration]
983 | adev->need_swiotlb = drm_need_swiotlb(44);
Signed-off-by: Aaron Liu <aaron.liu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
index f8fa27b7b53b..9ae8cdaa033e 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
@@ -22,6 +22,9 @@
*/
#include <linux/firmware.h>
#include <linux/pci.h>
+
+#include <drm/drm_cache.h>
+
#include "amdgpu.h"
#include "amdgpu_atomfirmware.h"
#include "gmc_v10_0.h"
--
2.37.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: add declaration of function ‘drm_need_swiotlb’ in gmc10.0
2022-07-25 1:30 [PATCH] drm/amdgpu: add declaration of function ‘drm_need_swiotlb’ in gmc10.0 Aaron Liu
@ 2022-07-25 1:37 ` Huang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Huang Rui @ 2022-07-25 1:37 UTC (permalink / raw)
To: Liu, Aaron; +Cc: Deucher, Alexander, amd-gfx@lists.freedesktop.org
On Mon, Jul 25, 2022 at 09:30:27AM +0800, Liu, Aaron wrote:
> Fixing compiling error:
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c: In function ‘gmc_v10_0_sw_init’:
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c:983:23: error: implicit declaration of function ‘drm_need_swiotlb’ [-Werror=implicit-function-declaration]
> 983 | adev->need_swiotlb = drm_need_swiotlb(44);
>
> Signed-off-by: Aaron Liu <aaron.liu@amd.com>
Please revert the one in the amd-staging-drm-next, and squeeze it into the
last one. We would better not separate them as two.
Please make sure the patch can be built successfully at least before push
it.
Thanks,
Ray
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> index f8fa27b7b53b..9ae8cdaa033e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
> @@ -22,6 +22,9 @@
> */
> #include <linux/firmware.h>
> #include <linux/pci.h>
> +
> +#include <drm/drm_cache.h>
> +
> #include "amdgpu.h"
> #include "amdgpu_atomfirmware.h"
> #include "gmc_v10_0.h"
> --
> 2.37.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-25 1:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-25 1:30 [PATCH] drm/amdgpu: add declaration of function ‘drm_need_swiotlb’ in gmc10.0 Aaron Liu
2022-07-25 1:37 ` Huang Rui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.