From: Vinod Koul <vkoul@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: kishon@ti.com, amelie.delaunay@foss.st.com,
alexandre.torgue@foss.st.com, linux-phy@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: stm32: fix error return in stm32_usbphyc_phy_init
Date: Fri, 15 Jul 2022 17:04:32 +0530 [thread overview]
Message-ID: <YtFQyBCc2IRXOptK@matsya> (raw)
In-Reply-To: <20220713133953.595134-1-fabrice.gasnier@foss.st.com>
On 13-07-22, 15:39, Fabrice Gasnier wrote:
> Error code is overridden, in case the PLL doesn't lock. So, the USB
> initialization can continue. This leads to a platform freeze.
> This can be avoided by returning proper error code to avoid USB probe
> freezing the platform. It also displays proper errors in log.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: kishon@ti.com, amelie.delaunay@foss.st.com,
alexandre.torgue@foss.st.com, linux-phy@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: stm32: fix error return in stm32_usbphyc_phy_init
Date: Fri, 15 Jul 2022 17:04:32 +0530 [thread overview]
Message-ID: <YtFQyBCc2IRXOptK@matsya> (raw)
In-Reply-To: <20220713133953.595134-1-fabrice.gasnier@foss.st.com>
On 13-07-22, 15:39, Fabrice Gasnier wrote:
> Error code is overridden, in case the PLL doesn't lock. So, the USB
> initialization can continue. This leads to a platform freeze.
> This can be avoided by returning proper error code to avoid USB probe
> freezing the platform. It also displays proper errors in log.
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: kishon@ti.com, amelie.delaunay@foss.st.com,
alexandre.torgue@foss.st.com, linux-phy@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: stm32: fix error return in stm32_usbphyc_phy_init
Date: Fri, 15 Jul 2022 17:04:32 +0530 [thread overview]
Message-ID: <YtFQyBCc2IRXOptK@matsya> (raw)
In-Reply-To: <20220713133953.595134-1-fabrice.gasnier@foss.st.com>
On 13-07-22, 15:39, Fabrice Gasnier wrote:
> Error code is overridden, in case the PLL doesn't lock. So, the USB
> initialization can continue. This leads to a platform freeze.
> This can be avoided by returning proper error code to avoid USB probe
> freezing the platform. It also displays proper errors in log.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2022-07-15 11:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 13:39 [PATCH] phy: stm32: fix error return in stm32_usbphyc_phy_init Fabrice Gasnier
2022-07-13 13:39 ` Fabrice Gasnier
2022-07-13 13:39 ` Fabrice Gasnier
2022-07-15 11:34 ` Vinod Koul [this message]
2022-07-15 11:34 ` Vinod Koul
2022-07-15 11:34 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtFQyBCc2IRXOptK@matsya \
--to=vkoul@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.