From: Vinod Koul <vkoul@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Frank Wunderlich <frank-w@public-files.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Geis <pgwipeout@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode
Date: Fri, 15 Jul 2022 17:18:32 +0530 [thread overview]
Message-ID: <YtFUEGgOGEQy7duZ@matsya> (raw)
In-Reply-To: <20220708061434.38115-1-samuel@sholland.org>
On 08-07-22, 01:14, Samuel Holland wrote:
> When the OTG port is fixed to host mode, the driver does not request its
> IRQs, nor does it enable those IRQs in hardware. Similarly, the driver
> should ignore the OTG port IRQs when handling the shared interrupt.
>
> Otherwise, it would update the extcon based on an ID pin which may be in
> an undefined state, or try to queue a uninitialized work item.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Frank Wunderlich <frank-w@public-files.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Geis <pgwipeout@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode
Date: Fri, 15 Jul 2022 17:18:32 +0530 [thread overview]
Message-ID: <YtFUEGgOGEQy7duZ@matsya> (raw)
In-Reply-To: <20220708061434.38115-1-samuel@sholland.org>
On 08-07-22, 01:14, Samuel Holland wrote:
> When the OTG port is fixed to host mode, the driver does not request its
> IRQs, nor does it enable those IRQs in hardware. Similarly, the driver
> should ignore the OTG port IRQs when handling the shared interrupt.
>
> Otherwise, it would update the extcon based on an ID pin which may be in
> an undefined state, or try to queue a uninitialized work item.
Applied, thanks
--
~Vinod
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Frank Wunderlich <frank-w@public-files.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Geis <pgwipeout@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode
Date: Fri, 15 Jul 2022 17:18:32 +0530 [thread overview]
Message-ID: <YtFUEGgOGEQy7duZ@matsya> (raw)
In-Reply-To: <20220708061434.38115-1-samuel@sholland.org>
On 08-07-22, 01:14, Samuel Holland wrote:
> When the OTG port is fixed to host mode, the driver does not request its
> IRQs, nor does it enable those IRQs in hardware. Similarly, the driver
> should ignore the OTG port IRQs when handling the shared interrupt.
>
> Otherwise, it would update the extcon based on an ID pin which may be in
> an undefined state, or try to queue a uninitialized work item.
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Frank Wunderlich <frank-w@public-files.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Geis <pgwipeout@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode
Date: Fri, 15 Jul 2022 17:18:32 +0530 [thread overview]
Message-ID: <YtFUEGgOGEQy7duZ@matsya> (raw)
In-Reply-To: <20220708061434.38115-1-samuel@sholland.org>
On 08-07-22, 01:14, Samuel Holland wrote:
> When the OTG port is fixed to host mode, the driver does not request its
> IRQs, nor does it enable those IRQs in hardware. Similarly, the driver
> should ignore the OTG port IRQs when handling the shared interrupt.
>
> Otherwise, it would update the extcon based on an ID pin which may be in
> an undefined state, or try to queue a uninitialized work item.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2022-07-15 11:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 6:14 [PATCH] phy: rockchip-inno-usb2: Ignore OTG IRQs in host mode Samuel Holland
2022-07-08 6:14 ` Samuel Holland
2022-07-08 6:14 ` Samuel Holland
2022-07-08 6:14 ` Samuel Holland
2022-07-08 11:47 ` Aw: " Frank Wunderlich
2022-07-08 11:47 ` Frank Wunderlich
2022-07-08 11:47 ` Frank Wunderlich
2022-07-08 11:47 ` Frank Wunderlich
2022-07-08 13:03 ` Peter Geis
2022-07-08 13:03 ` Peter Geis
2022-07-08 13:03 ` Peter Geis
2022-07-08 13:03 ` Peter Geis
2022-07-15 11:48 ` Vinod Koul [this message]
2022-07-15 11:48 ` Vinod Koul
2022-07-15 11:48 ` Vinod Koul
2022-07-15 11:48 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtFUEGgOGEQy7duZ@matsya \
--to=vkoul@kernel.org \
--cc=frank-w@public-files.de \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=samuel@sholland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.