From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: michal.winiarski@intel.com, airlied@linux.ie,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, zhou1615@umn.edu
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
Date: Mon, 18 Jul 2022 14:28:46 -0400 [thread overview]
Message-ID: <YtWmXu10XZLSGy+w@intel.com> (raw)
In-Reply-To: <20220715051953.31424-1-wangborong@cdjrlc.com>
On Fri, Jul 15, 2022 at 01:19:53PM +0800, Jason Wang wrote:
> The double `wait' is duplicated in line 974, remove one.
The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
> --
> 2.35.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: matthew.brost@intel.com, tvrtko.ursulin@linux.intel.com,
michal.winiarski@intel.com, andi.shyti@linux.intel.com,
airlied@linux.ie, intel-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
zhou1615@umn.edu, John.C.Harrison@intel.com
Subject: Re: [PATCH] drm/i915/selftests: Fix comment typo
Date: Mon, 18 Jul 2022 14:28:46 -0400 [thread overview]
Message-ID: <YtWmXu10XZLSGy+w@intel.com> (raw)
In-Reply-To: <20220715051953.31424-1-wangborong@cdjrlc.com>
On Fri, Jul 15, 2022 at 01:19:53PM +0800, Jason Wang wrote:
> The double `wait' is duplicated in line 974, remove one.
The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
> --
> 2.35.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jason Wang <wangborong@cdjrlc.com>
Cc: <daniel@ffwll.ch>, <jani.nikula@linux.intel.com>,
<joonas.lahtinen@linux.intel.com>,
<tvrtko.ursulin@linux.intel.com>, <airlied@linux.ie>,
<John.C.Harrison@intel.com>, <matthew.d.roper@intel.com>,
<matthew.brost@intel.com>, <andi.shyti@linux.intel.com>,
<michal.winiarski@intel.com>, <zhou1615@umn.edu>,
<intel-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/i915/selftests: Fix comment typo
Date: Mon, 18 Jul 2022 14:28:46 -0400 [thread overview]
Message-ID: <YtWmXu10XZLSGy+w@intel.com> (raw)
In-Reply-To: <20220715051953.31424-1-wangborong@cdjrlc.com>
On Fri, Jul 15, 2022 at 01:19:53PM +0800, Jason Wang wrote:
> The double `wait' is duplicated in line 974, remove one.
The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
> --
> 2.35.1
>
next prev parent reply other threads:[~2022-07-18 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 5:19 [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo Jason Wang
2022-07-15 5:19 ` Jason Wang
2022-07-15 5:19 ` Jason Wang
2022-07-18 18:28 ` Rodrigo Vivi [this message]
2022-07-18 18:28 ` Rodrigo Vivi
2022-07-18 18:28 ` Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2022-07-16 4:05 [Intel-gfx] " Jason Wang
2022-07-20 16:56 ` Andrzej Hajda
2022-07-21 8:08 ` Rodrigo Vivi
2022-07-21 8:08 ` Rodrigo Vivi
2022-07-21 13:08 ` Andi Shyti
2022-07-21 13:19 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtWmXu10XZLSGy+w@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.winiarski@intel.com \
--cc=wangborong@cdjrlc.com \
--cc=zhou1615@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.