From: Chris Down <chris@chrisdown.name>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 2/2] printk: console: Support console-specific loglevels
Date: Thu, 21 Jul 2022 17:29:59 +0100 [thread overview]
Message-ID: <Ytl/B6pLOCRYVc7p@chrisdown.name> (raw)
In-Reply-To: <202207220029.VYxE2uAL-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
kernel test robot writes:
>sparse warnings: (new ones prefixed by >>)
>>> kernel/printk/sysctl.c:31:47: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void * @@ got void [noderef] __user *buffer @@
> kernel/printk/sysctl.c:31:47: sparse: expected void *
> kernel/printk/sysctl.c:31:47: sparse: got void [noderef] __user *buffer
Ah, since commit 32927393dc1c ("sysctl: pass kernel pointers to
->proc_handler") we copy to kernelspace before passing to the callback, so it's
not a userspace pointer. That's certainly an improvement.
Will fix for v4.
WARNING: multiple messages have this Message-ID (diff)
From: Chris Down <chris@chrisdown.name>
To: kernel test robot <lkp@intel.com>
Cc: linux-kernel@vger.kernel.org, kbuild-all@lists.01.org,
Petr Mladek <pmladek@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
kernel-team@fb.com
Subject: Re: [PATCH v3 2/2] printk: console: Support console-specific loglevels
Date: Thu, 21 Jul 2022 17:29:59 +0100 [thread overview]
Message-ID: <Ytl/B6pLOCRYVc7p@chrisdown.name> (raw)
In-Reply-To: <202207220029.VYxE2uAL-lkp@intel.com>
kernel test robot writes:
>sparse warnings: (new ones prefixed by >>)
>>> kernel/printk/sysctl.c:31:47: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void * @@ got void [noderef] __user *buffer @@
> kernel/printk/sysctl.c:31:47: sparse: expected void *
> kernel/printk/sysctl.c:31:47: sparse: got void [noderef] __user *buffer
Ah, since commit 32927393dc1c ("sysctl: pass kernel pointers to
->proc_handler") we copy to kernelspace before passing to the callback, so it's
not a userspace pointer. That's certainly an improvement.
Will fix for v4.
next prev parent reply other threads:[~2022-07-21 16:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 17:48 [PATCH v3 0/2] printk: console: Per-console loglevels Chris Down
2022-07-20 17:48 ` [PATCH v3 1/2] printk: console: Create console= parser that supports named options Chris Down
2022-08-31 10:13 ` Petr Mladek
2022-09-05 14:43 ` Chris Down
2022-09-05 14:45 ` Chris Down
2022-09-22 15:17 ` Petr Mladek
2023-04-17 15:04 ` Chris Down
2023-04-17 15:08 ` Chris Down
2023-04-18 13:43 ` Petr Mladek
2023-04-18 13:41 ` Petr Mladek
2023-04-19 0:31 ` Chris Down
2022-07-20 17:48 ` [PATCH v3 2/2] printk: console: Support console-specific loglevels Chris Down
2022-07-21 9:50 ` kernel test robot
2022-07-21 16:20 ` Chris Down
2022-07-21 16:20 ` Chris Down
2022-07-21 16:16 ` kernel test robot
2022-07-21 16:29 ` Chris Down [this message]
2022-07-21 16:29 ` Chris Down
2022-09-01 9:35 ` Petr Mladek
2022-09-05 14:07 ` Chris Down
2022-09-05 15:12 ` Petr Mladek
2022-07-20 18:22 ` [PATCH v3 0/2] printk: console: Per-console loglevels John Ogness
2022-07-20 18:29 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytl/B6pLOCRYVc7p@chrisdown.name \
--to=chris@chrisdown.name \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.