From: Mike Snitzer <snitzer@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Mike Snitzer <snitzer@kernel.org>,
linux-kernel@vger.kernel.org,
Nathan Huckleberry <nhuck@google.com>,
Christoph Hellwig <hch@infradead.org>,
dm-devel@redhat.com, Sami Tolvanen <samitolvanen@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH 0/3] dm-verity: optionally use tasklets in dm-verity
Date: Fri, 22 Jul 2022 14:33:44 -0400 [thread overview]
Message-ID: <YtrtiP2p8xnRdC3S@redhat.com> (raw)
In-Reply-To: <cabd732a-9942-3ece-8141-c0bc6378faca@acm.org>
On Fri, Jul 22 2022 at 2:12P -0400,
Bart Van Assche <bvanassche@acm.org> wrote:
> On 7/22/22 09:41, Christoph Hellwig wrote:
> > We've been tying to kill off task lets for about 15 years. I don't
> > think adding new users will make you a whole lot of friends..
>
> +1 for not using tasklets. At least in Android the real-time thread
> scheduling latency is important. Tasklets are not visible to the scheduler
> and hence cause latency spikes for real-time threads. These latency spikes
> can be observed by users, e.g. if the real-time thread is involved in audio
> playback.
OK, then android wouldn't set the _optional_ "try_verify_in_tasklet"
Mike
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Nathan Huckleberry <nhuck@google.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Mike Snitzer <snitzer@kernel.org>,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>,
dm-devel@redhat.com, Sami Tolvanen <samitolvanen@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH 0/3] dm-verity: optionally use tasklets in dm-verity
Date: Fri, 22 Jul 2022 14:33:44 -0400 [thread overview]
Message-ID: <YtrtiP2p8xnRdC3S@redhat.com> (raw)
In-Reply-To: <cabd732a-9942-3ece-8141-c0bc6378faca@acm.org>
On Fri, Jul 22 2022 at 2:12P -0400,
Bart Van Assche <bvanassche@acm.org> wrote:
> On 7/22/22 09:41, Christoph Hellwig wrote:
> > We've been tying to kill off task lets for about 15 years. I don't
> > think adding new users will make you a whole lot of friends..
>
> +1 for not using tasklets. At least in Android the real-time thread
> scheduling latency is important. Tasklets are not visible to the scheduler
> and hence cause latency spikes for real-time threads. These latency spikes
> can be observed by users, e.g. if the real-time thread is involved in audio
> playback.
OK, then android wouldn't set the _optional_ "try_verify_in_tasklet"
Mike
next prev parent reply other threads:[~2022-07-22 18:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 9:38 [dm-devel] [PATCH 0/3] dm-verity: optionally use tasklets in dm-verity Nathan Huckleberry
2022-07-22 9:38 ` Nathan Huckleberry
2022-07-22 9:38 ` [dm-devel] [PATCH 1/3] dm-bufio: Add flags for dm_bufio_client_create Nathan Huckleberry
2022-07-22 9:38 ` Nathan Huckleberry
2022-07-22 9:38 ` [dm-devel] [PATCH 2/3] dm-bufio: Add DM_BUFIO_GET_CANT_SLEEP Nathan Huckleberry
2022-07-22 9:38 ` Nathan Huckleberry
2022-07-22 9:38 ` [dm-devel] [PATCH 3/3] dm-verity: Add try_verify_in_tasklet Nathan Huckleberry
2022-07-22 9:38 ` Nathan Huckleberry
2022-07-26 1:58 ` [dm-devel] " Mike Snitzer
2022-07-26 1:58 ` Mike Snitzer
2022-07-26 3:06 ` [dm-devel] " Eric Biggers
2022-07-26 3:06 ` Eric Biggers
2022-07-26 4:13 ` [dm-devel] " Mike Snitzer
2022-07-26 4:13 ` Mike Snitzer
2022-07-22 16:41 ` [dm-devel] [PATCH 0/3] dm-verity: optionally use tasklets in dm-verity Christoph Hellwig
2022-07-22 16:41 ` Christoph Hellwig
2022-07-22 17:12 ` [dm-devel] " Mike Snitzer
2022-07-22 17:12 ` Mike Snitzer
2022-08-15 11:35 ` Sebastian Andrzej Siewior
2022-07-22 18:12 ` [dm-devel] " Bart Van Assche
2022-07-22 18:12 ` Bart Van Assche
2022-07-22 18:33 ` Mike Snitzer [this message]
2022-07-22 18:33 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtrtiP2p8xnRdC3S@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=bvanassche@acm.org \
--cc=dm-devel@redhat.com \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhuck@google.com \
--cc=samitolvanen@google.com \
--cc=snitzer@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.