From: Sean Christopherson <seanjc@google.com>
To: kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, kvm@vger.kernel.org,
Robert Hu <robert.hu@intel.com>,
Farrah Chen <farrah.chen@intel.com>,
Danmei Wei <danmei.wei@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Mingwei Zhang <mizhang@google.com>
Subject: Re: [kvm:queue 23/35] arch/x86/kvm/mmu/mmu.c:6391:19: warning: variable 'pfn' set but not used
Date: Fri, 22 Jul 2022 23:49:52 +0000 [thread overview]
Message-ID: <Yts3oLhqJ2SNGurV@google.com> (raw)
In-Reply-To: <202207230706.VfX9Ycxh-lkp@intel.com>
On Sat, Jul 23, 2022, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
> head: 1a4d88a361af4f2e91861d632c6a1fe87a9665c2
> commit: fe631a46409403616aa0c28c2c16cae7f7c92b1e [23/35] KVM: x86/mmu: Don't require refcounted "struct page" to create huge SPTEs
> config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220723/202207230706.VfX9Ycxh-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/virt/kvm/kvm.git/commit/?id=fe631a46409403616aa0c28c2c16cae7f7c92b1e
> git remote add kvm https://git.kernel.org/pub/scm/virt/kvm/kvm.git
> git fetch --no-tags kvm queue
> git checkout fe631a46409403616aa0c28c2c16cae7f7c92b1e
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/kvm/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> arch/x86/kvm/mmu/mmu.c: In function 'kvm_mmu_zap_collapsible_spte':
> >> arch/x86/kvm/mmu/mmu.c:6391:19: warning: variable 'pfn' set but not used [-Wunused-but-set-variable]
> 6391 | kvm_pfn_t pfn;
> | ^~~
>
>
> vim +/pfn +6391 arch/x86/kvm/mmu/mmu.c
>
> a3fe5dbda0a4bb arch/x86/kvm/mmu/mmu.c David Matlack 2022-01-19 6383
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6384 static bool kvm_mmu_zap_collapsible_spte(struct kvm *kvm,
> 0a234f5dd06582 arch/x86/kvm/mmu/mmu.c Sean Christopherson 2021-02-12 6385 struct kvm_rmap_head *rmap_head,
> 269e9552d20817 arch/x86/kvm/mmu/mmu.c Hamza Mahfooz 2021-07-12 6386 const struct kvm_memory_slot *slot)
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6387 {
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6388 u64 *sptep;
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6389 struct rmap_iterator iter;
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6390 int need_tlb_flush = 0;
> ba049e93aef7e8 arch/x86/kvm/mmu.c Dan Williams 2016-01-15 @6391 kvm_pfn_t pfn;
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6392 struct kvm_mmu_page *sp;
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6393
> 0d5367900a319a arch/x86/kvm/mmu.c Xiao Guangrong 2015-05-13 6394 restart:
> 018aabb56d6109 arch/x86/kvm/mmu.c Takuya Yoshikawa 2015-11-20 6395 for_each_rmap_spte(rmap_head, &iter, sptep) {
> 573546820b792e arch/x86/kvm/mmu/mmu.c Sean Christopherson 2020-06-22 6396 sp = sptep_to_sp(sptep);
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6397 pfn = spte_to_pfn(*sptep);
Dagnabbit, I caught the TDP MMU case where "pfn" was completely unused, but not
this one. I'll send a fixup/follow-up.
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: kbuild-all@lists.01.org
Subject: Re: [kvm:queue 23/35] arch/x86/kvm/mmu/mmu.c:6391:19: warning: variable 'pfn' set but not used
Date: Mon, 25 Jul 2022 16:58:21 +0000 [thread overview]
Message-ID: <Yts3oLhqJ2SNGurV@google.com> (raw)
In-Reply-To: <202207230706.VfX9Ycxh-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3123 bytes --]
On Sat, Jul 23, 2022, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
> head: 1a4d88a361af4f2e91861d632c6a1fe87a9665c2
> commit: fe631a46409403616aa0c28c2c16cae7f7c92b1e [23/35] KVM: x86/mmu: Don't require refcounted "struct page" to create huge SPTEs
> config: x86_64-randconfig-a015 (https://download.01.org/0day-ci/archive/20220723/202207230706.VfX9Ycxh-lkp(a)intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/virt/kvm/kvm.git/commit/?id=fe631a46409403616aa0c28c2c16cae7f7c92b1e
> git remote add kvm https://git.kernel.org/pub/scm/virt/kvm/kvm.git
> git fetch --no-tags kvm queue
> git checkout fe631a46409403616aa0c28c2c16cae7f7c92b1e
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/kvm/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> arch/x86/kvm/mmu/mmu.c: In function 'kvm_mmu_zap_collapsible_spte':
> >> arch/x86/kvm/mmu/mmu.c:6391:19: warning: variable 'pfn' set but not used [-Wunused-but-set-variable]
> 6391 | kvm_pfn_t pfn;
> | ^~~
>
>
> vim +/pfn +6391 arch/x86/kvm/mmu/mmu.c
>
> a3fe5dbda0a4bb arch/x86/kvm/mmu/mmu.c David Matlack 2022-01-19 6383
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6384 static bool kvm_mmu_zap_collapsible_spte(struct kvm *kvm,
> 0a234f5dd06582 arch/x86/kvm/mmu/mmu.c Sean Christopherson 2021-02-12 6385 struct kvm_rmap_head *rmap_head,
> 269e9552d20817 arch/x86/kvm/mmu/mmu.c Hamza Mahfooz 2021-07-12 6386 const struct kvm_memory_slot *slot)
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6387 {
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6388 u64 *sptep;
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6389 struct rmap_iterator iter;
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6390 int need_tlb_flush = 0;
> ba049e93aef7e8 arch/x86/kvm/mmu.c Dan Williams 2016-01-15 @6391 kvm_pfn_t pfn;
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6392 struct kvm_mmu_page *sp;
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6393
> 0d5367900a319a arch/x86/kvm/mmu.c Xiao Guangrong 2015-05-13 6394 restart:
> 018aabb56d6109 arch/x86/kvm/mmu.c Takuya Yoshikawa 2015-11-20 6395 for_each_rmap_spte(rmap_head, &iter, sptep) {
> 573546820b792e arch/x86/kvm/mmu/mmu.c Sean Christopherson 2020-06-22 6396 sp = sptep_to_sp(sptep);
> 3ea3b7fa9af067 arch/x86/kvm/mmu.c Wanpeng Li 2015-04-03 6397 pfn = spte_to_pfn(*sptep);
Dagnabbit, I caught the TDP MMU case where "pfn" was completely unused, but not
this one. I'll send a fixup/follow-up.
next prev parent reply other threads:[~2022-07-22 23:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 23:40 [kvm:queue 23/35] arch/x86/kvm/mmu/mmu.c:6391:19: warning: variable 'pfn' set but not used kernel test robot
2022-07-22 23:49 ` Sean Christopherson [this message]
2022-07-25 16:58 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yts3oLhqJ2SNGurV@google.com \
--to=seanjc@google.com \
--cc=danmei.wei@intel.com \
--cc=farrah.chen@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=kvm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
--cc=robert.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.