From: Sean Paul <sean@poorly.run>
To: Jim Shargo <jshargo@chromium.org>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Melissa Wen <melissa.srw@gmail.com>,
jshargo@google.com
Subject: Re: [PATCH 3/5] drm/vkms: Support multiple objects (crtcs, etc.) per card
Date: Fri, 5 Aug 2022 18:34:27 +0000 [thread overview]
Message-ID: <Yu1is1ZNl9RSwAHQ@art_vandelay> (raw)
In-Reply-To: <Yu1g/PLuU559SIm7@art_vandelay>
On Fri, Aug 05, 2022 at 06:27:08PM +0000, Sean Paul wrote:
> On Fri, Jul 22, 2022 at 05:32:10PM -0400, Jim Shargo wrote:
> > This is a small refactor to make ConfigFS support easier.
> >
> > We now store the vkms_device statically, and maintain a list of
> > "cards", each representing a different virtual DRM driver.
> >
> > We also make it clear when a card is "default", that is created at
> > initialization, and not. This is because, due to limitations on what we
> > can do with the configfs API, the default card won't be reflected in
> > configfs and is initialized in a unique way.
> >
> > Since we're only managing a single card, this should be a no-op.
> >
> > Signed-off-by: Jim Shargo <jshargo@chromium.org>
/snip
What a mess, I replied to the wrong patch. The review here is targeting PATCH
2/5 despite the title and reply-to.
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run>
To: Jim Shargo <jshargo@chromium.org>
Cc: jshargo@google.com,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
Melissa Wen <melissa.srw@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] drm/vkms: Support multiple objects (crtcs, etc.) per card
Date: Fri, 5 Aug 2022 18:34:27 +0000 [thread overview]
Message-ID: <Yu1is1ZNl9RSwAHQ@art_vandelay> (raw)
In-Reply-To: <Yu1g/PLuU559SIm7@art_vandelay>
On Fri, Aug 05, 2022 at 06:27:08PM +0000, Sean Paul wrote:
> On Fri, Jul 22, 2022 at 05:32:10PM -0400, Jim Shargo wrote:
> > This is a small refactor to make ConfigFS support easier.
> >
> > We now store the vkms_device statically, and maintain a list of
> > "cards", each representing a different virtual DRM driver.
> >
> > We also make it clear when a card is "default", that is created at
> > initialization, and not. This is because, due to limitations on what we
> > can do with the configfs API, the default card won't be reflected in
> > configfs and is initialized in a unique way.
> >
> > Since we're only managing a single card, this should be a no-op.
> >
> > Signed-off-by: Jim Shargo <jshargo@chromium.org>
/snip
What a mess, I replied to the wrong patch. The review here is targeting PATCH
2/5 despite the title and reply-to.
next prev parent reply other threads:[~2022-08-05 18:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220722213214.1377835-1-jshargo@chromium.org>
2022-07-22 21:32 ` [PATCH 1/5] drm/vkms: Merge default_config and device Jim Shargo
2022-07-22 21:32 ` Jim Shargo
2022-08-05 15:39 ` Sean Paul
2022-08-05 15:39 ` Sean Paul
2022-07-22 21:32 ` [PATCH 2/5] drm/vkms: VKMS now supports more than one "card" Jim Shargo
2022-07-22 21:32 ` Jim Shargo
2022-08-05 18:36 ` Sean Paul
2022-08-05 18:36 ` Sean Paul
2022-07-22 21:32 ` [PATCH 3/5] drm/vkms: Support multiple objects (crtcs, etc.) per card Jim Shargo
2022-07-22 21:32 ` Jim Shargo
2022-08-05 18:27 ` Sean Paul
2022-08-05 18:27 ` Sean Paul
2022-08-05 18:34 ` Sean Paul [this message]
2022-08-05 18:34 ` Sean Paul
2022-08-05 20:03 ` Sean Paul
2022-08-05 20:03 ` Sean Paul
2022-07-22 21:32 ` [PATCH 4/5] drm/vkms: Add ConfigFS scaffolding to VKMS Jim Shargo
2022-07-22 21:32 ` Jim Shargo
2022-08-05 21:23 ` Sean Paul
2022-08-05 21:23 ` Sean Paul
2022-07-22 21:32 ` [PATCH 5/5] drm/vkms: Support registering configfs devices Jim Shargo
2022-07-22 21:32 ` Jim Shargo
2022-08-08 15:15 ` Sean Paul
2022-08-08 15:15 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yu1is1ZNl9RSwAHQ@art_vandelay \
--to=sean@poorly.run \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=jshargo@chromium.org \
--cc=jshargo@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=melissa.srw@gmail.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.