* [PATCH] ASoC: amd: acp: uninitialized variable in i2s_irq_handler()
@ 2022-07-27 13:40 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-07-27 13:40 UTC (permalink / raw)
To: Liam Girdwood, Venkata Prasad Potturu
Cc: alsa-devel, Charles Keepax, Ajit Kumar Pandey, Yang Yingliang,
kernel-janitors, Takashi Iwai, Mark Brown, Vijendar Mukunda,
V sujith kumar Reddy
The "ext_intr_stat1" is used without being initialized.
Fixes: 93f53881473c ("ASoC: amd: acp: Modify local variables name to generic")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/soc/amd/acp/acp-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
index 10730d33c3b0..f561d39b33e2 100644
--- a/sound/soc/amd/acp/acp-platform.c
+++ b/sound/soc/amd/acp/acp-platform.c
@@ -100,7 +100,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)
return IRQ_NONE;
if (adata->rsrc->no_of_ctrls == 2)
- ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));
+ ext_intr_stat1 = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));
ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ASoC: amd: acp: uninitialized variable in i2s_irq_handler()
@ 2022-07-27 13:40 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-07-27 13:40 UTC (permalink / raw)
To: Liam Girdwood, Venkata Prasad Potturu
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Ajit Kumar Pandey,
Vijendar Mukunda, V sujith kumar Reddy, Charles Keepax,
Yang Yingliang, alsa-devel, kernel-janitors
The "ext_intr_stat1" is used without being initialized.
Fixes: 93f53881473c ("ASoC: amd: acp: Modify local variables name to generic")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/soc/amd/acp/acp-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
index 10730d33c3b0..f561d39b33e2 100644
--- a/sound/soc/amd/acp/acp-platform.c
+++ b/sound/soc/amd/acp/acp-platform.c
@@ -100,7 +100,7 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)
return IRQ_NONE;
if (adata->rsrc->no_of_ctrls == 2)
- ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));
+ ext_intr_stat1 = readl(ACP_EXTERNAL_INTR_STAT(adata, (rsrc->irqp_used - 1)));
ext_intr_stat = readl(ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: amd: acp: uninitialized variable in i2s_irq_handler()
2022-07-27 13:40 ` Dan Carpenter
@ 2022-07-27 14:15 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-07-27 14:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: alsa-devel, Charles Keepax, Ajit Kumar Pandey,
Venkata Prasad Potturu, Yang Yingliang, kernel-janitors,
Takashi Iwai, Liam Girdwood, Vijendar Mukunda,
V sujith kumar Reddy
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
On Wed, Jul 27, 2022 at 04:40:05PM +0300, Dan Carpenter wrote:
> The "ext_intr_stat1" is used without being initialized.
Someone submitted a patch for this yesterday.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: amd: acp: uninitialized variable in i2s_irq_handler()
@ 2022-07-27 14:15 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-07-27 14:15 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Venkata Prasad Potturu, Jaroslav Kysela,
Takashi Iwai, Ajit Kumar Pandey, Vijendar Mukunda,
V sujith kumar Reddy, Charles Keepax, Yang Yingliang, alsa-devel,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
On Wed, Jul 27, 2022 at 04:40:05PM +0300, Dan Carpenter wrote:
> The "ext_intr_stat1" is used without being initialized.
Someone submitted a patch for this yesterday.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-27 14:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-27 13:40 [PATCH] ASoC: amd: acp: uninitialized variable in i2s_irq_handler() Dan Carpenter
2022-07-27 13:40 ` Dan Carpenter
2022-07-27 14:15 ` Mark Brown
2022-07-27 14:15 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.