From: Mark Brown <broonie@kernel.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
swboyd@chromium.org, tiwai@suse.com, lgirdwood@gmail.com,
robh+dt@kernel.org, bjorn.andersson@linaro.org,
agross@kernel.org, srinivas.kandagatla@linaro.org,
bgoswami@quicinc.com, quic_plai@quicinc.com,
judyhsiao@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: SC7280: Add support for external DMIC bias supply
Date: Thu, 28 Jul 2022 11:49:41 +0100 [thread overview]
Message-ID: <YuJpxSuPBB++pl/o@sirena.org.uk> (raw)
In-Reply-To: <1658992233-28372-1-git-send-email-quic_srivasam@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
On Thu, Jul 28, 2022 at 12:40:33PM +0530, Srinivasa Rao Mandadapu wrote:
> +static int sc7280_dmic_micbias(struct snd_soc_dapm_widget *w,
> + struct snd_kcontrol *kcontrol, int event)
> +{
> + struct snd_soc_card *card = w->dapm->card;
> + struct sc7280_snd_data *data = snd_soc_card_get_drvdata(card);
> + int ret = 0;
> +
This is open coding SND_SOC_DAPM_REGULATOR_SUPPLY() isn't it?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, robh+dt@kernel.org, quic_plai@quicinc.com,
bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com,
srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, swboyd@chromium.org,
judyhsiao@chromium.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: SC7280: Add support for external DMIC bias supply
Date: Thu, 28 Jul 2022 11:49:41 +0100 [thread overview]
Message-ID: <YuJpxSuPBB++pl/o@sirena.org.uk> (raw)
In-Reply-To: <1658992233-28372-1-git-send-email-quic_srivasam@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
On Thu, Jul 28, 2022 at 12:40:33PM +0530, Srinivasa Rao Mandadapu wrote:
> +static int sc7280_dmic_micbias(struct snd_soc_dapm_widget *w,
> + struct snd_kcontrol *kcontrol, int event)
> +{
> + struct snd_soc_card *card = w->dapm->card;
> + struct sc7280_snd_data *data = snd_soc_card_get_drvdata(card);
> + int ret = 0;
> +
This is open coding SND_SOC_DAPM_REGULATOR_SUPPLY() isn't it?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-07-28 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 7:10 [PATCH] ASoC: qcom: SC7280: Add support for external DMIC bias supply Srinivasa Rao Mandadapu
2022-07-28 10:49 ` Mark Brown [this message]
2022-07-28 10:49 ` Mark Brown
2022-07-28 13:06 ` Srinivasa Rao Mandadapu
2022-07-28 13:06 ` Srinivasa Rao Mandadapu
2022-07-28 12:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuJpxSuPBB++pl/o@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.