All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] firmware/psci: Add debugfs support to ease debugging
Date: Thu, 28 Jul 2022 14:38:04 +0100	[thread overview]
Message-ID: <YuKRPB/Ilb0al3ro@sirena.org.uk> (raw)
In-Reply-To: <20220727200901.1142557-1-dmitry.baryshkov@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Wed, Jul 27, 2022 at 11:09:01PM +0300, Dmitry Baryshkov wrote:

> +} psci_fn_ids[] = {
> +	PSCI_ID_NATIVE(0_2, MIGRATE),
> +	PSCI_ID(0_2, MIGRATE_INFO_TYPE),
> +	PSCI_ID_NATIVE(0_2, MIGRATE_INFO_UP_CPU),
> +	PSCI_ID(1_0, CPU_FREEZE),
> +	PSCI_ID_NATIVE(1_0, CPU_DEFAULT_SUSPEND),
> +	PSCI_ID_NATIVE(1_0, NODE_HW_STATE),
> +	PSCI_ID_NATIVE(1_0, SYSTEM_SUSPEND),
> +	PSCI_ID(1_0, SET_SUSPEND_MODE),
> +	PSCI_ID_NATIVE(1_0, STAT_RESIDENCY),
> +	PSCI_ID_NATIVE(1_0, STAT_COUNT),
> +	PSCI_ID_NATIVE(1_1, SYSTEM_RESET2),
> +};

There's other functions like the MEM_PROTECT ones which we don't
currently use but it might be interesting to enumerate...

>  #define PSCI_1_0_FN_PSCI_FEATURES		PSCI_0_2_FN(10)
> +#define PSCI_1_0_FN_CPU_FREEZE			PSCI_0_2_FN(11)
> +#define PSCI_1_0_FN_CPU_DEFAULT_SUSPEND		PSCI_0_2_FN(12)

...we're already adding functions here.

> +#define PSCI_1_0_FN_NODE_HW_STATE		PSCI_0_2_FN(13)

> +#define PSCI_1_0_FN_STAT_RESIDENCY		PSCI_0_2_FN(16)
> +#define PSCI_1_0_FN_STAT_COUNT			PSCI_0_2_FN(17)

Some of these state query things might be interesting to actually call
and output results from at some point, doesn't seem like something that
should be a blocker though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] firmware/psci: Add debugfs support to ease debugging
Date: Thu, 28 Jul 2022 14:38:04 +0100	[thread overview]
Message-ID: <YuKRPB/Ilb0al3ro@sirena.org.uk> (raw)
In-Reply-To: <20220727200901.1142557-1-dmitry.baryshkov@linaro.org>


[-- Attachment #1.1: Type: text/plain, Size: 1191 bytes --]

On Wed, Jul 27, 2022 at 11:09:01PM +0300, Dmitry Baryshkov wrote:

> +} psci_fn_ids[] = {
> +	PSCI_ID_NATIVE(0_2, MIGRATE),
> +	PSCI_ID(0_2, MIGRATE_INFO_TYPE),
> +	PSCI_ID_NATIVE(0_2, MIGRATE_INFO_UP_CPU),
> +	PSCI_ID(1_0, CPU_FREEZE),
> +	PSCI_ID_NATIVE(1_0, CPU_DEFAULT_SUSPEND),
> +	PSCI_ID_NATIVE(1_0, NODE_HW_STATE),
> +	PSCI_ID_NATIVE(1_0, SYSTEM_SUSPEND),
> +	PSCI_ID(1_0, SET_SUSPEND_MODE),
> +	PSCI_ID_NATIVE(1_0, STAT_RESIDENCY),
> +	PSCI_ID_NATIVE(1_0, STAT_COUNT),
> +	PSCI_ID_NATIVE(1_1, SYSTEM_RESET2),
> +};

There's other functions like the MEM_PROTECT ones which we don't
currently use but it might be interesting to enumerate...

>  #define PSCI_1_0_FN_PSCI_FEATURES		PSCI_0_2_FN(10)
> +#define PSCI_1_0_FN_CPU_FREEZE			PSCI_0_2_FN(11)
> +#define PSCI_1_0_FN_CPU_DEFAULT_SUSPEND		PSCI_0_2_FN(12)

...we're already adding functions here.

> +#define PSCI_1_0_FN_NODE_HW_STATE		PSCI_0_2_FN(13)

> +#define PSCI_1_0_FN_STAT_RESIDENCY		PSCI_0_2_FN(16)
> +#define PSCI_1_0_FN_STAT_COUNT			PSCI_0_2_FN(17)

Some of these state query things might be interesting to actually call
and output results from at some point, doesn't seem like something that
should be a blocker though.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-07-28 13:38 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-27 20:09 [PATCH] firmware/psci: Add debugfs support to ease debugging Dmitry Baryshkov
2022-07-27 20:09 ` Dmitry Baryshkov
2022-07-27 20:15 ` Bhupesh Sharma
2022-07-27 20:15   ` Bhupesh Sharma
2022-07-27 20:53   ` Dmitry Baryshkov
2022-07-27 20:53     ` Dmitry Baryshkov
2022-07-27 20:55     ` Bhupesh Sharma
2022-07-27 20:55       ` Bhupesh Sharma
2022-07-27 20:56       ` Dmitry Baryshkov
2022-07-27 20:56         ` Dmitry Baryshkov
2022-07-27 20:59         ` Bhupesh Sharma
2022-07-27 20:59           ` Bhupesh Sharma
2022-07-27 21:03           ` Dmitry Baryshkov
2022-07-27 21:03             ` Dmitry Baryshkov
2022-07-28  9:08 ` Sudeep Holla
2022-07-28  9:08   ` Sudeep Holla
2022-07-28  9:20   ` Dmitry Baryshkov
2022-07-28  9:20     ` Dmitry Baryshkov
2022-07-29 18:45     ` Florian Fainelli
2022-07-29 18:45       ` Florian Fainelli
2022-08-01  9:59       ` Sudeep Holla
2022-08-01  9:59         ` Sudeep Holla
2022-08-01 12:14         ` Mark Brown
2022-08-01 12:14           ` Mark Brown
2022-08-01 13:30           ` Sudeep Holla
2022-08-01 13:30             ` Sudeep Holla
2022-07-28 13:05   ` Mark Brown
2022-07-28 13:05     ` Mark Brown
2022-07-29 11:49     ` Sudeep Holla
2022-07-29 11:49       ` Sudeep Holla
2022-07-28 13:38 ` Mark Brown [this message]
2022-07-28 13:38   ` Mark Brown
2022-07-29 14:55   ` Dmitry Baryshkov
2022-07-29 14:55     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuKRPB/Ilb0al3ro@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.