From: Sam Ravnborg <sam@ravnborg.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Molly Sophia <mollysophia379@gmail.com>,
Sumit Semwal <sumit.semwal@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] drm: panel: Add novatek nt35596s panel driver
Date: Thu, 28 Jul 2022 15:50:45 +0200 [thread overview]
Message-ID: <YuKUNeazoho6LPTJ@ravnborg.org> (raw)
In-Reply-To: <1685ecd6-cfe7-c2f1-add5-6bfff055fa06@linaro.org>
Hi Krzysztof
On Thu, Jul 28, 2022 at 02:17:29PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2022 04:35, Molly Sophia wrote:
> > Novatek NT35596s is a generic DSI IC that drives command and video mode
> > panels. Add the driver for it. Currently add support for the LCD panel
> > from JDI connected with this IC, as found on Xiaomi Mi Mix2s phones.
> >
> > Changes in v4:
> > - No change.
> >
> > Changes in v3:
> > - Embed the support into existing driver (panel-novatek-nt36672a), as
> > these two IC are similar with different initialization commands.
> >
>
> This does not go to commit msg (---).
It depends...
In the drm sub-system the general rule is if someone cares to write it,
then it deserves to be added to the commit message.
So for drm patches it is perfectly fine to have the history part
included in the commit message.
These sub-system differences does not makes it easier - I know.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
~postmarketos/upstreaming@lists.sr.ht,
Molly Sophia <mollysophia379@gmail.com>,
phone-devel@vger.kernel.org,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [PATCH v4 2/2] drm: panel: Add novatek nt35596s panel driver
Date: Thu, 28 Jul 2022 15:50:45 +0200 [thread overview]
Message-ID: <YuKUNeazoho6LPTJ@ravnborg.org> (raw)
In-Reply-To: <1685ecd6-cfe7-c2f1-add5-6bfff055fa06@linaro.org>
Hi Krzysztof
On Thu, Jul 28, 2022 at 02:17:29PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2022 04:35, Molly Sophia wrote:
> > Novatek NT35596s is a generic DSI IC that drives command and video mode
> > panels. Add the driver for it. Currently add support for the LCD panel
> > from JDI connected with this IC, as found on Xiaomi Mi Mix2s phones.
> >
> > Changes in v4:
> > - No change.
> >
> > Changes in v3:
> > - Embed the support into existing driver (panel-novatek-nt36672a), as
> > these two IC are similar with different initialization commands.
> >
>
> This does not go to commit msg (---).
It depends...
In the drm sub-system the general rule is if someone cares to write it,
then it deserves to be added to the commit message.
So for drm patches it is perfectly fine to have the history part
included in the commit message.
These sub-system differences does not makes it easier - I know.
Sam
next prev parent reply other threads:[~2022-07-28 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 2:35 [PATCH v4 0/2] Add driver for Novatek NT35596S panel Molly Sophia
2022-07-28 2:35 ` Molly Sophia
2022-07-28 2:35 ` [PATCH v4 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings Molly Sophia
2022-07-28 2:35 ` Molly Sophia
2022-07-28 12:17 ` Krzysztof Kozlowski
2022-07-28 12:17 ` Krzysztof Kozlowski
2022-07-28 2:35 ` [PATCH v4 2/2] drm: panel: Add novatek nt35596s panel driver Molly Sophia
2022-07-28 2:35 ` Molly Sophia
2022-07-28 12:17 ` Krzysztof Kozlowski
2022-07-28 12:17 ` Krzysztof Kozlowski
2022-07-28 13:50 ` Sam Ravnborg [this message]
2022-07-28 13:50 ` Sam Ravnborg
2022-07-28 14:07 ` Krzysztof Kozlowski
2022-07-28 14:07 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuKUNeazoho6LPTJ@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mollysophia379@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.