All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	stable@vger.kernel.org, linux-block@vger.kernel.org,
	dm-devel@redhat.com,
	syzbot+4f441e6ca0fcad141421@syzkaller.appspotmail.com,
	Tadeusz Struk <tadeusz.struk@linaro.org>
Subject: Re: [dm-devel] [PATCH 5.10 1/2] block: split bio_kmalloc from bio_alloc_bioset
Date: Thu, 28 Jul 2022 17:00:16 +0200	[thread overview]
Message-ID: <YuKkgPx2XF6rQnLq@kroah.com> (raw)
In-Reply-To: <20220728144520.GA18285@lst.de>

On Thu, Jul 28, 2022 at 04:45:20PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 28, 2022 at 04:42:35PM +0200, Greg KH wrote:
> > > > Link: https://syzkaller.appspot.com/bug?id=a3416231e37024a75f2b95bd95db0d8ce8132a84
> > > 
> > > Both now queued up, thanks.
> > 
> > As was just reported, this breaks things all over the place:
> > 	https://lore.kernel.org/r/219030d8-3408-cc9d-7aec-1fb14ab891ce@roeck-us.net
> > 
> > Note, I also had to add lots of fix-up patches on top of these two that
> > you missed, so odds are there are other fix-ups that I also missed.
> > 
> > Please go and test this again, and submit ALL patches that are needed
> > after they pass the proper testing and I will be glad to reconsider them
> > again.
> 
> Why did this even get backported?  It was a cleanup that required a lot
> of prep work, and should not by itself fix anything.

Looks like syzkaller is reporting something odd...

Tadeusz, how was this tested?

thanks,

greg k-h

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Tadeusz Struk <tadeusz.struk@linaro.org>,
	stable@vger.kernel.org, linux-block@vger.kernel.org,
	dm-devel@redhat.com,
	syzbot+4f441e6ca0fcad141421@syzkaller.appspotmail.com,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 5.10 1/2] block: split bio_kmalloc from bio_alloc_bioset
Date: Thu, 28 Jul 2022 17:00:16 +0200	[thread overview]
Message-ID: <YuKkgPx2XF6rQnLq@kroah.com> (raw)
In-Reply-To: <20220728144520.GA18285@lst.de>

On Thu, Jul 28, 2022 at 04:45:20PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 28, 2022 at 04:42:35PM +0200, Greg KH wrote:
> > > > Link: https://syzkaller.appspot.com/bug?id=a3416231e37024a75f2b95bd95db0d8ce8132a84
> > > 
> > > Both now queued up, thanks.
> > 
> > As was just reported, this breaks things all over the place:
> > 	https://lore.kernel.org/r/219030d8-3408-cc9d-7aec-1fb14ab891ce@roeck-us.net
> > 
> > Note, I also had to add lots of fix-up patches on top of these two that
> > you missed, so odds are there are other fix-ups that I also missed.
> > 
> > Please go and test this again, and submit ALL patches that are needed
> > after they pass the proper testing and I will be glad to reconsider them
> > again.
> 
> Why did this even get backported?  It was a cleanup that required a lot
> of prep work, and should not by itself fix anything.

Looks like syzkaller is reporting something odd...

Tadeusz, how was this tested?

thanks,

greg k-h

  reply	other threads:[~2022-07-28 15:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 21:12 [dm-devel] [PATCH 5.10 1/2] block: split bio_kmalloc from bio_alloc_bioset Tadeusz Struk
2022-07-18 21:12 ` Tadeusz Struk
2022-07-18 21:12 ` [dm-devel] [PATCH 5.10 2/2] block: fix bounce_clone_bio for passthrough bios Tadeusz Struk
2022-07-18 21:12   ` Tadeusz Struk
2022-07-23 14:59 ` [dm-devel] [PATCH 5.10 1/2] block: split bio_kmalloc from bio_alloc_bioset Greg KH
2022-07-23 14:59   ` Greg KH
2022-07-28 14:42   ` [dm-devel] " Greg KH
2022-07-28 14:42     ` Greg KH
2022-07-28 14:45     ` [dm-devel] " Christoph Hellwig
2022-07-28 14:45       ` Christoph Hellwig
2022-07-28 15:00       ` Greg KH [this message]
2022-07-28 15:00         ` Greg KH
2022-07-28 15:19         ` [dm-devel] " Tadeusz Struk
2022-07-28 15:19           ` Tadeusz Struk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YuKkgPx2XF6rQnLq@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=axboe@kernel.dk \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=hch@lst.de \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+4f441e6ca0fcad141421@syzkaller.appspotmail.com \
    --cc=tadeusz.struk@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.