From: Andrew Lunn <andrew@lunn.ch>
To: Oliver Neukum <oneukum@suse.com>
Cc: hayeswang@realtek.com, netdev@vger.kernel.org
Subject: Re: [RFC] r8152: pass through needs to be singular
Date: Fri, 29 Jul 2022 00:11:16 +0200 [thread overview]
Message-ID: <YuMJhAuZVVZtl9VZ@lunn.ch> (raw)
In-Reply-To: <20220728191851.30402-1-oneukum@suse.com>
On Thu, Jul 28, 2022 at 09:18:51PM +0200, Oliver Neukum wrote:
> If multiple devices are connected only one of them
> is allowed to get the pass through MAC
Is that true? Ethernet switches often use the same MAC address on
multiple ports. It is not inherently broken to have the same MAC
address on multiple interfaces.
We also need to watch out for regressions. There could be users who do
have the same MAC address on multiple interfaces, and it works for
them. With this change it is a 50/50 chance they no longer get the MAC
address they expect, depending on probe order.
We know this implementation of pass through it very broken, but
unfortunately, it is there, and we have to follow the normal
regression rules, even if we really would like to throw it all out.
What exactly is your problem which you are trying to fix?
Andrew
next prev parent reply other threads:[~2022-07-28 22:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 19:18 [RFC] r8152: pass through needs to be singular Oliver Neukum
2022-07-28 22:11 ` Andrew Lunn [this message]
2022-08-02 10:52 ` Oliver Neukum
2022-08-02 13:31 ` Andrew Lunn
2022-08-04 9:24 ` Oliver Neukum
2022-08-04 13:24 ` Andrew Lunn
2022-08-04 13:29 ` Oliver Neukum
2022-08-04 14:31 ` Andrew Lunn
2022-08-03 3:48 ` Hayes Wang
2022-08-04 8:57 ` Oliver Neukum
2022-08-08 7:04 ` Hayes Wang
2022-08-23 7:53 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuMJhAuZVVZtl9VZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.