From: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
Christian Brauner
<brauner-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org,
Namhyung Kim <namhyung-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pablo Neira Ayuso <pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org>
Subject: Re: [PATCH v2 cgroup/for-5.20] cgroup: Replace cgroup->ancestor_ids[] with ->ancestors[]
Date: Sat, 30 Jul 2022 00:42:09 +0200 [thread overview]
Message-ID: <YuRiQc35guAWcbjt@blackbook> (raw)
In-Reply-To: <YuRJ7uzKY5/fokH5-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
On Fri, Jul 29, 2022 at 10:58:22AM -1000, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> @@ -520,8 +520,8 @@ struct cgroup_root {
> /* The root cgroup. Root is destroyed on its release. */
> struct cgroup cgrp;
>
> - /* for cgrp->ancestor_ids[0] */
> - u64 cgrp_ancestor_id_storage;
> + /* for cgrp->ancestors[0] */
> + u64 cgrp_ancestor_storage;
Just noticed, this member is (and was AFAICS) superfluous.
Michal
WARNING: multiple messages have this Message-ID (diff)
From: "Michal Koutný" <mkoutny@suse.com>
To: Tejun Heo <tj@kernel.org>
Cc: cgroups@vger.kernel.org, Zefan Li <lizefan.x@bytedance.com>,
Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org, kernel-team@fb.com,
Namhyung Kim <namhyung@kernel.org>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH v2 cgroup/for-5.20] cgroup: Replace cgroup->ancestor_ids[] with ->ancestors[]
Date: Sat, 30 Jul 2022 00:42:09 +0200 [thread overview]
Message-ID: <YuRiQc35guAWcbjt@blackbook> (raw)
In-Reply-To: <YuRJ7uzKY5/fokH5@slm.duckdns.org>
On Fri, Jul 29, 2022 at 10:58:22AM -1000, Tejun Heo <tj@kernel.org> wrote:
> @@ -520,8 +520,8 @@ struct cgroup_root {
> /* The root cgroup. Root is destroyed on its release. */
> struct cgroup cgrp;
>
> - /* for cgrp->ancestor_ids[0] */
> - u64 cgrp_ancestor_id_storage;
> + /* for cgrp->ancestors[0] */
> + u64 cgrp_ancestor_storage;
Just noticed, this member is (and was AFAICS) superfluous.
Michal
next prev parent reply other threads:[~2022-07-29 22:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 19:05 [PATCH cgroup/for-5.20] cgroup: Replace cgroup->ancestor_ids[] with ->ancestors[] Tejun Heo
2022-07-29 19:05 ` Tejun Heo
[not found] ` <YuQvcCrcgNWbtndU-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-07-29 20:30 ` Namhyung Kim
2022-07-29 20:30 ` Namhyung Kim
2022-07-29 20:58 ` [PATCH v2 " Tejun Heo
2022-07-29 20:58 ` Tejun Heo
[not found] ` <YuRJ7uzKY5/fokH5-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-07-29 22:42 ` Michal Koutný [this message]
2022-07-29 22:42 ` Michal Koutný
2022-07-29 23:02 ` Tejun Heo
2022-07-29 23:02 ` Tejun Heo
2022-07-29 23:10 ` [PATCH v3 " Tejun Heo
2022-08-15 21:17 ` Tejun Heo
[not found] ` <Yvq33G14AU0cuswB-NiLfg/pYEd1N0TnZuCh8vA@public.gmane.org>
2022-09-22 4:05 ` Namhyung Kim
2022-09-22 4:05 ` Namhyung Kim
2022-09-22 4:14 ` [PATCH] perf stat: Support old kernels for bperf cgroup counting Namhyung Kim
2022-09-22 4:14 ` Namhyung Kim
2022-09-24 3:22 ` Tejun Heo
2022-09-30 20:30 ` Namhyung Kim
2022-09-30 20:30 ` Namhyung Kim
2022-09-30 21:43 ` Jiri Olsa
2022-09-30 21:56 ` Namhyung Kim
2022-09-30 21:56 ` Namhyung Kim
2022-09-30 22:00 ` Arnaldo Carvalho de Melo
2022-09-30 22:00 ` Arnaldo Carvalho de Melo
2022-09-30 22:11 ` Namhyung Kim
2022-09-30 22:11 ` Namhyung Kim
2022-10-01 13:57 ` Jiri Olsa
2022-10-01 13:57 ` Jiri Olsa
2022-09-30 22:48 ` Andrii Nakryiko
2022-10-01 2:31 ` Namhyung Kim
2022-10-05 22:36 ` Andrii Nakryiko
2022-10-05 22:36 ` Andrii Nakryiko
2022-10-01 13:58 ` Jiri Olsa
2022-10-01 13:58 ` Jiri Olsa
2022-10-10 23:59 ` Tejun Heo
2022-10-11 5:24 ` Namhyung Kim
2022-10-11 5:24 ` Namhyung Kim
2022-10-11 5:28 ` [PATCH v2] " Namhyung Kim
2022-10-11 5:28 ` Namhyung Kim
2022-10-11 16:53 ` Tejun Heo
2022-10-14 13:27 ` Arnaldo Carvalho de Melo
2022-10-14 13:30 ` Arnaldo Carvalho de Melo
2022-10-14 13:30 ` Arnaldo Carvalho de Melo
2022-10-14 16:40 ` Tejun Heo
2022-10-14 16:40 ` Tejun Heo
2022-10-14 17:10 ` Arnaldo Carvalho de Melo
2022-10-14 17:10 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuRiQc35guAWcbjt@blackbook \
--to=mkoutny-ibi9rg/b67k@public.gmane.org \
--cc=brauner-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org \
--cc=namhyung-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=pablo-Cap9r6Oaw4JrovVCs/uTlw@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.