From: Russell King (Oracle) <linux@armlinux.org.uk>
To: kbuild-all@lists.01.org
Subject: Re: [linux-next:master 4676/13542] drivers/remoteproc/rcar_rproc.c:45:20: sparse: sparse: incorrect type in argument 1 (different address spaces)
Date: Sat, 30 Jul 2022 13:41:52 +0100 [thread overview]
Message-ID: <YuUnEPFYPQtcEU9h@shell.armlinux.org.uk> (raw)
In-Reply-To: <202207301837.luqV6gPB-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
On Sat, Jul 30, 2022 at 07:08:06PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 7c5e07b73ff3011c9b82d4a3286a3362b951ad2b
> commit: d803336abdbc1bfacdb32b2cf9f4fdbee072b8ee [4676/13542] ARM: mm: kill unused runtime hook arch_iounmap()
This is not a bug in this commit; this commit does not need fixing. This
is a bug in drivers/remoteproc/rcar_rproc.c:
struct rproc_mem_entry {
void *va;
static int rcar_rproc_mem_alloc(struct rproc *rproc,
struct rproc_mem_entry *mem)
{
void *va;
va = ioremap_wc(mem->dma, mem->len);
This is a bug.
static int rcar_rproc_mem_release(struct rproc *rproc,
struct rproc_mem_entry *mem)
{
iounmap(mem->va);
This is also a bug.
drivers/remoteproc/rcar_rproc.c needs fixing not to ignore the __iomem
annotation when dealing with iomem.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: kernel test robot <lkp@intel.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Will Deacon <will@kernel.org>, Christoph Hellwig <hch@lst.de>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [linux-next:master 4676/13542] drivers/remoteproc/rcar_rproc.c:45:20: sparse: sparse: incorrect type in argument 1 (different address spaces)
Date: Sat, 30 Jul 2022 13:41:52 +0100 [thread overview]
Message-ID: <YuUnEPFYPQtcEU9h@shell.armlinux.org.uk> (raw)
In-Reply-To: <202207301837.luqV6gPB-lkp@intel.com>
On Sat, Jul 30, 2022 at 07:08:06PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 7c5e07b73ff3011c9b82d4a3286a3362b951ad2b
> commit: d803336abdbc1bfacdb32b2cf9f4fdbee072b8ee [4676/13542] ARM: mm: kill unused runtime hook arch_iounmap()
This is not a bug in this commit; this commit does not need fixing. This
is a bug in drivers/remoteproc/rcar_rproc.c:
struct rproc_mem_entry {
void *va;
static int rcar_rproc_mem_alloc(struct rproc *rproc,
struct rproc_mem_entry *mem)
{
void *va;
va = ioremap_wc(mem->dma, mem->len);
This is a bug.
static int rcar_rproc_mem_release(struct rproc *rproc,
struct rproc_mem_entry *mem)
{
iounmap(mem->va);
This is also a bug.
drivers/remoteproc/rcar_rproc.c needs fixing not to ignore the __iomem
annotation when dealing with iomem.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-07-30 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 11:08 [linux-next:master 4676/13542] drivers/remoteproc/rcar_rproc.c:45:20: sparse: sparse: incorrect type in argument 1 (different address spaces) kernel test robot
2022-07-30 12:41 ` Russell King [this message]
2022-07-30 12:41 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuUnEPFYPQtcEU9h@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.