From: Sam Ravnborg <sam@ravnborg.org>
To: Danilo Krummrich <dakr@redhat.com>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
kraxel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/virtio: remove drm_plane_cleanup() destroy hook
Date: Wed, 3 Aug 2022 20:31:07 +0200 [thread overview]
Message-ID: <Yuq+63QAyOYQvbvX@ravnborg.org> (raw)
In-Reply-To: <20220803145520.1143208-1-dakr@redhat.com>
Hi Danilo,
On Wed, Aug 03, 2022 at 04:55:20PM +0200, Danilo Krummrich wrote:
> drmm_universal_plane_alloc() already registers drm_plane_cleanup() as
> managed release action via drmm_add_action_or_reset(). Hence,
> drm_plane_cleanup() should not be set as drm_plane_funcs.destroy hook.
>
> Fixes: 7847628862a8 ("drm/virtio: plane: use drm managed resources")
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/virtio/virtgpu_plane.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
> index c599c99f228e..4c09e313bebc 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> @@ -69,7 +69,6 @@ uint32_t virtio_gpu_translate_format(uint32_t drm_fourcc)
> static const struct drm_plane_funcs virtio_gpu_plane_funcs = {
> .update_plane = drm_atomic_helper_update_plane,
> .disable_plane = drm_atomic_helper_disable_plane,
> - .destroy = drm_plane_cleanup,
> .reset = drm_atomic_helper_plane_reset,
> .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
> .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
> --
> 2.37.1
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Danilo Krummrich <dakr@redhat.com>
Cc: airlied@linux.ie, daniel@ffwll.ch, kraxel@redhat.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/virtio: remove drm_plane_cleanup() destroy hook
Date: Wed, 3 Aug 2022 20:31:07 +0200 [thread overview]
Message-ID: <Yuq+63QAyOYQvbvX@ravnborg.org> (raw)
In-Reply-To: <20220803145520.1143208-1-dakr@redhat.com>
Hi Danilo,
On Wed, Aug 03, 2022 at 04:55:20PM +0200, Danilo Krummrich wrote:
> drmm_universal_plane_alloc() already registers drm_plane_cleanup() as
> managed release action via drmm_add_action_or_reset(). Hence,
> drm_plane_cleanup() should not be set as drm_plane_funcs.destroy hook.
>
> Fixes: 7847628862a8 ("drm/virtio: plane: use drm managed resources")
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> drivers/gpu/drm/virtio/virtgpu_plane.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
> index c599c99f228e..4c09e313bebc 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> @@ -69,7 +69,6 @@ uint32_t virtio_gpu_translate_format(uint32_t drm_fourcc)
> static const struct drm_plane_funcs virtio_gpu_plane_funcs = {
> .update_plane = drm_atomic_helper_update_plane,
> .disable_plane = drm_atomic_helper_disable_plane,
> - .destroy = drm_plane_cleanup,
> .reset = drm_atomic_helper_plane_reset,
> .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
> .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
> --
> 2.37.1
next prev parent reply other threads:[~2022-08-03 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 14:55 [PATCH] drm/virtio: remove drm_plane_cleanup() destroy hook Danilo Krummrich
2022-08-03 14:55 ` Danilo Krummrich
2022-08-03 18:31 ` Sam Ravnborg [this message]
2022-08-03 18:31 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yuq+63QAyOYQvbvX@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dakr@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.