Re: [PATCH v2 08/10] log: create log.decorateFilter=all

[Josh Steadmon <steadmon@google.com>]

On 2022.07.29 19:29, Derrick Stolee via GitGitGadget wrote:
> From: Derrick Stolee <derrickstolee@github.com>
> 
> The previous change introduced the --decorate-all option for users who
> do not want their decorations limited to a narrow set of ref namespaces.
> 
> Add a config option that is equivalent to specifying --decorate-all by
> default.
> 
> Signed-off-by: Derrick Stolee <derrickstolee@github.com>
> ---
>  Documentation/config/log.txt |  5 +++++
>  Documentation/git-log.txt    |  4 +++-
>  builtin/log.c                | 12 ++++++++++++
>  t/t4202-log.sh               |  3 +++
>  t/t9902-completion.sh        |  3 +++
>  5 files changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/config/log.txt b/Documentation/config/log.txt
> index 456eb07800c..615cb26e5c9 100644
> --- a/Documentation/config/log.txt
> +++ b/Documentation/config/log.txt
> @@ -18,6 +18,11 @@ log.decorate::
>  	names are shown. This is the same as the `--decorate` option
>  	of the `git log`.
>  
> +log.decorateFilter::
> +	By default, `git log` only shows decorations for certain known ref
> +	namespaces. If 'all' is specified, then show all possible ref
> +	decorations. Default value is 'default'.
> +

Could we make it more clear here that "all" is the only supported value?
IIUC any other value will just get the default behavior. Just reading
the doc as-is, I worry that users might expect that they can add
specific refs / ref-patterns that would be added to the filter.