All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Cc: linux-nfs@vger.kernel.org, Martin Doucha <martin.doucha@suse.com>,
	Li Wang <liwang@redhat.com>, Cyril Hrubis <chrubis@suse.cz>
Subject: Re: [PATCH v2 5/9] tst_test.sh: Add $TST_ALL_FILESYSTEMS
Date: Thu, 4 Aug 2022 09:07:45 +0200	[thread overview]
Message-ID: <YutwQfLa2O01OyNE@pevik> (raw)
In-Reply-To: <20220609214223.4608-6-pvorel@suse.cz>

Hi all,

I wonder if we want to sort filesystems:

-for _tst_fs in $(tst_supported_fs); do
+for _tst_fs in $(tst_supported_fs | sort); do

or even -u (as uniq).

Martin used it in testcases/misc/lvm/prepare_lvm.sh, but IMHO it should not be
needed: looping over fs_type_whitelist() should be always the same.

FS_LIST=`tst_supported_fs | sort -u`

Therefore I'd remove it (don't use unnecessary dependencies - be nice for people
with minimal environment):

Kind regards,
Petr

WARNING: multiple messages have this Message-ID (diff)
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Cc: linux-nfs@vger.kernel.org, Martin Doucha <martin.doucha@suse.com>
Subject: Re: [LTP] [PATCH v2 5/9] tst_test.sh: Add $TST_ALL_FILESYSTEMS
Date: Thu, 4 Aug 2022 09:07:45 +0200	[thread overview]
Message-ID: <YutwQfLa2O01OyNE@pevik> (raw)
In-Reply-To: <20220609214223.4608-6-pvorel@suse.cz>

Hi all,

I wonder if we want to sort filesystems:

-for _tst_fs in $(tst_supported_fs); do
+for _tst_fs in $(tst_supported_fs | sort); do

or even -u (as uniq).

Martin used it in testcases/misc/lvm/prepare_lvm.sh, but IMHO it should not be
needed: looping over fs_type_whitelist() should be always the same.

FS_LIST=`tst_supported_fs | sort -u`

Therefore I'd remove it (don't use unnecessary dependencies - be nice for people
with minimal environment):

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-08-04  7:07 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09 21:42 [PATCH 0/9] shell: nfs: $TST_ALL_FILESYSTEMS (.all_filesystems) Petr Vorel
2022-06-09 21:42 ` [LTP] " Petr Vorel
2022-06-09 21:42 ` [PATCH v2 1/9] tst_test.sh: Add $TST_MOUNT_DEVICE Petr Vorel
2022-06-09 21:42   ` [LTP] " Petr Vorel
2022-06-09 21:42 ` [PATCH v2 2/9] df01.sh: Use TST_MOUNT_DEVICE=1 Petr Vorel
2022-06-09 21:42   ` [LTP] " Petr Vorel
2022-06-09 21:42 ` [PATCH v2 3/9] tst_test.sh: allow ' in pattern for allowed variables Petr Vorel
2022-06-09 21:42   ` [LTP] " Petr Vorel
2022-06-17 11:59   ` Cyril Hrubis
2022-06-17 11:59     ` Cyril Hrubis
2022-06-09 21:42 ` [PATCH v2 4/9] shell: Add test for TST_MOUNT_DEVICE=1 Petr Vorel
2022-06-09 21:42   ` [LTP] " Petr Vorel
2022-07-11 15:02   ` Petr Vorel
2022-07-11 15:02     ` [LTP] " Petr Vorel
2022-06-09 21:42 ` [PATCH v2 5/9] tst_test.sh: Add $TST_ALL_FILESYSTEMS Petr Vorel
2022-06-09 21:42   ` [LTP] " Petr Vorel
2022-06-17 13:52   ` Cyril Hrubis
2022-06-17 13:52     ` Cyril Hrubis
2022-06-17 14:07     ` Petr Vorel
2022-06-17 14:07       ` Petr Vorel
2022-08-04  7:07   ` Petr Vorel [this message]
2022-08-04  7:07     ` Petr Vorel
2022-06-09 21:42 ` [PATCH v2 6/9] tst_device: Remove unnecessary braces Petr Vorel
2022-06-09 21:42   ` [LTP] " Petr Vorel
2022-06-17 13:57   ` Cyril Hrubis
2022-06-17 13:57     ` Cyril Hrubis
2022-06-09 21:42 ` [PATCH v2 7/9] tst_device: Add clear command Petr Vorel
2022-06-09 21:42   ` [LTP] " Petr Vorel
2022-06-17 14:02   ` Cyril Hrubis
2022-06-17 14:02     ` Cyril Hrubis
2022-06-09 21:42 ` [PATCH v2 8/9] shell: Add test for TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-06-09 21:42   ` [LTP] " Petr Vorel
2022-06-16  5:59   ` Li Wang
2022-06-09 21:42 ` [RFC][PATCH v2 9/9] nfs: Use TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-06-09 21:42   ` [LTP] " Petr Vorel
2022-06-16  6:11   ` Li Wang
2022-06-16  6:51     ` Petr Vorel
2022-06-16  6:51       ` Petr Vorel
2022-06-17 14:51   ` Cyril Hrubis
2022-06-17 14:51     ` Cyril Hrubis
2022-07-11 15:08     ` Petr Vorel
2022-07-11 15:08       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YutwQfLa2O01OyNE@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=linux-nfs@vger.kernel.org \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=martin.doucha@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.