All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: gadget: rndis: use %u instead of %d to print u32 values
@ 2022-08-04 11:08 Ray Hung
  2022-08-04 11:25 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Ray Hung @ 2022-08-04 11:08 UTC (permalink / raw)
  To: balbi
  Cc: gregkh, akpm, tw.rayhung, dh10.jung, songmuchun, dan.carpenter,
	linux-usb, linux-kernel

The driver uses the %d format to print u32 values. The correct
format is %u. Fix it.

Signed-off-by: Ray Hung <tw.rayhung@gmail.com>
---
 drivers/usb/gadget/function/rndis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
index 713efd9aefde..10ba339bcea4 100644
--- a/drivers/usb/gadget/function/rndis.c
+++ b/drivers/usb/gadget/function/rndis.c
@@ -1105,7 +1105,7 @@ static int rndis_proc_show(struct seq_file *m, void *v)
 			 "used      : %s\n"
 			 "state     : %s\n"
 			 "medium    : 0x%08X\n"
-			 "speed     : %d\n"
+			 "speed     : %u\n"
 			 "cable     : %s\n"
 			 "vendor ID : 0x%08X\n"
 			 "vendor    : %s\n",
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: rndis: use %u instead of %d to print u32 values
  2022-08-04 11:08 [PATCH] usb: gadget: rndis: use %u instead of %d to print u32 values Ray Hung
@ 2022-08-04 11:25 ` Greg KH
  2022-08-04 12:07   ` Ray Hung
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2022-08-04 11:25 UTC (permalink / raw)
  To: Ray Hung
  Cc: balbi, akpm, dh10.jung, songmuchun, dan.carpenter, linux-usb,
	linux-kernel

On Thu, Aug 04, 2022 at 07:08:36PM +0800, Ray Hung wrote:
> The driver uses the %d format to print u32 values. The correct
> format is %u. Fix it.
> 
> Signed-off-by: Ray Hung <tw.rayhung@gmail.com>
> ---
>  drivers/usb/gadget/function/rndis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
> index 713efd9aefde..10ba339bcea4 100644
> --- a/drivers/usb/gadget/function/rndis.c
> +++ b/drivers/usb/gadget/function/rndis.c
> @@ -1105,7 +1105,7 @@ static int rndis_proc_show(struct seq_file *m, void *v)
>  			 "used      : %s\n"
>  			 "state     : %s\n"
>  			 "medium    : 0x%08X\n"
> -			 "speed     : %d\n"
> +			 "speed     : %u\n"
>  			 "cable     : %s\n"
>  			 "vendor ID : 0x%08X\n"
>  			 "vendor    : %s\n",
> -- 
> 2.25.1
> 

What commit id does this fix?

And given this is only for debugging, there's no rush, right?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: rndis: use %u instead of %d to print u32 values
  2022-08-04 11:25 ` Greg KH
@ 2022-08-04 12:07   ` Ray Hung
  0 siblings, 0 replies; 3+ messages in thread
From: Ray Hung @ 2022-08-04 12:07 UTC (permalink / raw)
  To: Greg KH
  Cc: balbi, akpm, dh10.jung, songmuchun, dan.carpenter, linux-usb,
	linux-kernel

Hi,

What commit id does this fix?
> It's 1da177e4c3f4

And given this is only for debugging, there's no rush, right?
> Yes, only for debugging

Thanks!

Ray

Greg KH <gregkh@linuxfoundation.org> 於 2022年8月4日 週四 晚上7:25寫道：
>
> On Thu, Aug 04, 2022 at 07:08:36PM +0800, Ray Hung wrote:
> > The driver uses the %d format to print u32 values. The correct
> > format is %u. Fix it.
> >
> > Signed-off-by: Ray Hung <tw.rayhung@gmail.com>
> > ---
> >  drivers/usb/gadget/function/rndis.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c
> > index 713efd9aefde..10ba339bcea4 100644
> > --- a/drivers/usb/gadget/function/rndis.c
> > +++ b/drivers/usb/gadget/function/rndis.c
> > @@ -1105,7 +1105,7 @@ static int rndis_proc_show(struct seq_file *m, void *v)
> >                        "used      : %s\n"
> >                        "state     : %s\n"
> >                        "medium    : 0x%08X\n"
> > -                      "speed     : %d\n"
> > +                      "speed     : %u\n"
> >                        "cable     : %s\n"
> >                        "vendor ID : 0x%08X\n"
> >                        "vendor    : %s\n",
> > --
> > 2.25.1
> >
>
> What commit id does this fix?
>
> And given this is only for debugging, there's no rush, right?
>
> thanks,
>
> greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-04 12:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-04 11:08 [PATCH] usb: gadget: rndis: use %u instead of %d to print u32 values Ray Hung
2022-08-04 11:25 ` Greg KH
2022-08-04 12:07   ` Ray Hung

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.