Re: [PATCH 4/4] Input: xpad - add support for XBOX One Elite paddles

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Aug 18, 2022 at 03:00:21PM +0200, Pavel Rojtberg wrote:
> From: Christopher Crockett <chaorace@gmail.com>
> 
> An effort has been made to support every official model and firmware
> version I could track down info on. The following controllers _should_
> have working paddles with this PR:
> - Xbox Elite (**untested**)
> - Xbox Elite Series 2 on early firmwares (**untested**)
> - Xbox Elite Series 2 on v4 firmwares (Tested v4.8.1908.0)
> - Xbox Elite Series 2 on v5 pre-BLE firmwares (**untested**)
> - Xbox Elite Series 2 on v5 post-BLE firmwares (Tested v5.13.3143.0)
> 
> This patch also introduces correct handling for the Elite 1 controller
> and properly suppresses paddle inputs when using a custom profile slot.
> 
> Starting with firmware v5.11, certain inputs for the Elite 2 were moved
> to an extra packet that is not enabled by default.
> 
> We must first manually enable this extra packet in order to correctly
> process paddle input data with these later firmwares.
> 
> Signed-off-by: Christopher Crockett <chaorace@gmail.com>
> Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
> ---
>  drivers/input/joystick/xpad.c | 254 +++++++++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 193 insertions(+), 61 deletions(-)

Nice work, that's messy to figure out.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>