From: Greg KH <gregkh@linuxfoundation.org>
To: Pavel Rojtberg <rojtberg@gmail.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
Cameron Gutman <aicommander@gmail.com>
Subject: Re: [PATCH 2/4] Input: xpad - fix wireless 360 controller breaking after suspend
Date: Thu, 18 Aug 2022 16:07:15 +0200 [thread overview]
Message-ID: <Yv5Hk7+8TY+SETlc@kroah.com> (raw)
In-Reply-To: <69d7663a-eaab-124b-4e68-83567c79c56f@gmail.com>
On Thu, Aug 18, 2022 at 03:51:55PM +0200, Pavel Rojtberg wrote:
> Am 18.08.22 um 15:10 schrieb Greg KH:
> > On Thu, Aug 18, 2022 at 03:00:19PM +0200, Pavel Rojtberg wrote:
> >> From: Cameron Gutman <aicommander@gmail.com>
> >>
> >> Suspending and resuming the system can sometimes cause the out
> >> URB to get hung after a reset_resume. This causes LED setting
> >> and force feedback to break on resume. To avoid this, just drop
> >> the reset_resume callback so the USB core rebinds xpad to the
> >> wireless pads on resume if a reset happened.
> >>
> >> A nice side effect of this change is the LED ring on wireless
> >> controllers is now set correctly on system resume.
> >>
> >> Signed-off-by: Cameron Gutman <aicommander@gmail.com>
> >> Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
> >> ---
> >> drivers/input/joystick/xpad.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >
> > What commit id does this fix? Should it go to stable kernels?
> >
> > thanks,
> >
> > greg k-h
>
> this is a fixup for 4220f7db1e424f2a086ad41217b5770cc9f003a9.
Great, can you resend and add the Fixes: tag for it like:
Fixes: 4220f7db1e42 ("Input: xpad - workaround dead irq_out after suspend/ resume")
> It should be applied to stable kernels, too.
Great, it needs a stable tag too.
thanks,
greg k-h
next prev parent reply other threads:[~2022-08-18 14:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 13:00 [PATCH 0/4] Input: xpad - sync with github fork Pavel Rojtberg
2022-08-18 13:00 ` [PATCH 1/4] Input: xpad - add supported devices as contributed on github Pavel Rojtberg
2022-08-18 13:10 ` Greg KH
2022-08-18 13:46 ` Pavel Rojtberg
2022-08-18 14:06 ` Greg KH
2022-08-18 13:00 ` [PATCH 2/4] Input: xpad - fix wireless 360 controller breaking after suspend Pavel Rojtberg
2022-08-18 13:10 ` Greg KH
2022-08-18 13:51 ` Pavel Rojtberg
2022-08-18 14:07 ` Greg KH [this message]
2022-08-18 13:00 ` [PATCH 3/4] Input: xpad - Poweroff XBOX360W on mode button long press Pavel Rojtberg
2022-08-18 13:11 ` Greg KH
2022-08-18 13:53 ` Pavel Rojtberg
2022-08-18 14:07 ` Greg KH
2022-08-18 13:00 ` [PATCH 4/4] Input: xpad - add support for XBOX One Elite paddles Pavel Rojtberg
2022-08-18 13:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv5Hk7+8TY+SETlc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aicommander@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=rojtberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.