* [PATCH] ASoC: amd: acp: remove unnecessary NULL checks
@ 2022-08-19 5:23 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-08-19 5:23 UTC (permalink / raw)
To: Liam Girdwood, Ajit Kumar Pandey
Cc: alsa-devel, Charles Keepax, Venkata Prasad Potturu,
kernel-janitors, Takashi Iwai, Nathan Chancellor, Mark Brown,
Vijendar Mukunda, V sujith kumar Reddy
The list iterator can never be NULL. Delete the bogus NULL checks.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/soc/amd/acp/acp-platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
index beee53aedeaf..85a81add4ef9 100644
--- a/sound/soc/amd/acp/acp-platform.c
+++ b/sound/soc/amd/acp/acp-platform.c
@@ -106,14 +106,14 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)
spin_lock(&adata->acp_lock);
list_for_each_entry(stream, &adata->stream_list, list) {
- if (stream && (ext_intr_stat & stream->irq_bit)) {
+ if (ext_intr_stat & stream->irq_bit) {
writel(stream->irq_bit,
ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));
snd_pcm_period_elapsed(stream->substream);
i2s_flag = 1;
}
if (adata->rsrc->no_of_ctrls == 2) {
- if (stream && (ext_intr_stat1 & stream->irq_bit)) {
+ if (ext_intr_stat1 & stream->irq_bit) {
writel(stream->irq_bit, ACP_EXTERNAL_INTR_STAT(adata,
(rsrc->irqp_used - 1)));
snd_pcm_period_elapsed(stream->substream);
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ASoC: amd: acp: remove unnecessary NULL checks
@ 2022-08-19 5:23 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-08-19 5:23 UTC (permalink / raw)
To: Liam Girdwood, Ajit Kumar Pandey
Cc: Mark Brown, Jaroslav Kysela, Takashi Iwai, Venkata Prasad Potturu,
Vijendar Mukunda, V sujith kumar Reddy, Nathan Chancellor,
Charles Keepax, alsa-devel, kernel-janitors
The list iterator can never be NULL. Delete the bogus NULL checks.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
sound/soc/amd/acp/acp-platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
index beee53aedeaf..85a81add4ef9 100644
--- a/sound/soc/amd/acp/acp-platform.c
+++ b/sound/soc/amd/acp/acp-platform.c
@@ -106,14 +106,14 @@ static irqreturn_t i2s_irq_handler(int irq, void *data)
spin_lock(&adata->acp_lock);
list_for_each_entry(stream, &adata->stream_list, list) {
- if (stream && (ext_intr_stat & stream->irq_bit)) {
+ if (ext_intr_stat & stream->irq_bit) {
writel(stream->irq_bit,
ACP_EXTERNAL_INTR_STAT(adata, rsrc->irqp_used));
snd_pcm_period_elapsed(stream->substream);
i2s_flag = 1;
}
if (adata->rsrc->no_of_ctrls == 2) {
- if (stream && (ext_intr_stat1 & stream->irq_bit)) {
+ if (ext_intr_stat1 & stream->irq_bit) {
writel(stream->irq_bit, ACP_EXTERNAL_INTR_STAT(adata,
(rsrc->irqp_used - 1)));
snd_pcm_period_elapsed(stream->substream);
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: amd: acp: remove unnecessary NULL checks
2022-08-19 5:23 ` Dan Carpenter
@ 2022-08-19 22:47 ` Mark Brown
-1 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-08-19 22:47 UTC (permalink / raw)
To: Dan Carpenter, Liam Girdwood, Ajit Kumar Pandey
Cc: alsa-devel, Charles Keepax, Venkata Prasad Potturu,
kernel-janitors, Takashi Iwai, Nathan Chancellor,
Vijendar Mukunda, V sujith kumar Reddy
On Fri, 19 Aug 2022 08:23:09 +0300, Dan Carpenter wrote:
> The list iterator can never be NULL. Delete the bogus NULL checks.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: amd: acp: remove unnecessary NULL checks
commit: a74ec0bf5b67eae87317646571116ce4b4166d95
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: amd: acp: remove unnecessary NULL checks
@ 2022-08-19 22:47 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-08-19 22:47 UTC (permalink / raw)
To: Dan Carpenter, Liam Girdwood, Ajit Kumar Pandey
Cc: Venkata Prasad Potturu, alsa-devel, V sujith kumar Reddy,
Takashi Iwai, Nathan Chancellor, kernel-janitors,
Vijendar Mukunda, Jaroslav Kysela, Charles Keepax
On Fri, 19 Aug 2022 08:23:09 +0300, Dan Carpenter wrote:
> The list iterator can never be NULL. Delete the bogus NULL checks.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: amd: acp: remove unnecessary NULL checks
commit: a74ec0bf5b67eae87317646571116ce4b4166d95
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-19 22:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-19 5:23 [PATCH] ASoC: amd: acp: remove unnecessary NULL checks Dan Carpenter
2022-08-19 5:23 ` Dan Carpenter
2022-08-19 22:47 ` Mark Brown
2022-08-19 22:47 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.