All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Peter Collingbourne <pcc@google.com>,
	stable@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH][for-stable] arm64: set UXN on swapper page tables
Date: Mon, 8 Aug 2022 15:23:55 +0200	[thread overview]
Message-ID: <YvEOa/l7zcukaqle@kroah.com> (raw)
In-Reply-To: <20220808125321.32598-1-will@kernel.org>

On Mon, Aug 08, 2022 at 01:53:21PM +0100, Will Deacon wrote:
> From: Peter Collingbourne <pcc@google.com>
> 
> [ This issue was fixed upstream by accident in c3cee924bd85 ("arm64:
>   head: cover entire kernel image in initial ID map") as part of a
>   large refactoring of the arm64 boot flow. This simple fix is therefore
>   preferred for -stable backporting ]
> 
> On a system that implements FEAT_EPAN, read/write access to the idmap
> is denied because UXN is not set on the swapper PTEs. As a result,
> idmap_kpti_install_ng_mappings panics the kernel when accessing
> __idmap_kpti_flag. Fix it by setting UXN on these PTEs.
> 
> Fixes: 18107f8a2df6 ("arm64: Support execute-only permissions with Enhanced PAN")
> Cc: <stable@vger.kernel.org> # 5.15
> Link: https://linux-review.googlesource.com/id/Ic452fa4b4f74753e54f71e61027e7222a0fae1b1
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Acked-by: Will Deacon <will@kernel.org>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Link: https://lore.kernel.org/r/20220719234909.1398992-1-pcc@google.com
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
>  arch/arm64/include/asm/kernel-pgtable.h | 4 ++--
>  arch/arm64/kernel/head.S                | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

So this should be added to 5.15.y, 5.18.y, and 5.19.y?  Or some subset?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Will Deacon <will@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Peter Collingbourne <pcc@google.com>,
	stable@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: [PATCH][for-stable] arm64: set UXN on swapper page tables
Date: Mon, 8 Aug 2022 15:23:55 +0200	[thread overview]
Message-ID: <YvEOa/l7zcukaqle@kroah.com> (raw)
In-Reply-To: <20220808125321.32598-1-will@kernel.org>

On Mon, Aug 08, 2022 at 01:53:21PM +0100, Will Deacon wrote:
> From: Peter Collingbourne <pcc@google.com>
> 
> [ This issue was fixed upstream by accident in c3cee924bd85 ("arm64:
>   head: cover entire kernel image in initial ID map") as part of a
>   large refactoring of the arm64 boot flow. This simple fix is therefore
>   preferred for -stable backporting ]
> 
> On a system that implements FEAT_EPAN, read/write access to the idmap
> is denied because UXN is not set on the swapper PTEs. As a result,
> idmap_kpti_install_ng_mappings panics the kernel when accessing
> __idmap_kpti_flag. Fix it by setting UXN on these PTEs.
> 
> Fixes: 18107f8a2df6 ("arm64: Support execute-only permissions with Enhanced PAN")
> Cc: <stable@vger.kernel.org> # 5.15
> Link: https://linux-review.googlesource.com/id/Ic452fa4b4f74753e54f71e61027e7222a0fae1b1
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Acked-by: Will Deacon <will@kernel.org>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Link: https://lore.kernel.org/r/20220719234909.1398992-1-pcc@google.com
> Signed-off-by: Will Deacon <will@kernel.org>
> ---
>  arch/arm64/include/asm/kernel-pgtable.h | 4 ++--
>  arch/arm64/kernel/head.S                | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

So this should be added to 5.15.y, 5.18.y, and 5.19.y?  Or some subset?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-08-08 13:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 12:53 [PATCH][for-stable] arm64: set UXN on swapper page tables Will Deacon
2022-08-08 12:53 ` Will Deacon
2022-08-08 13:23 ` Greg KH [this message]
2022-08-08 13:23   ` Greg KH
2022-08-09  8:33   ` Will Deacon
2022-08-09  8:33     ` Will Deacon
2022-08-08 13:25 ` Patch "arm64: set UXN on swapper page tables" has been added to the 5.15-stable tree gregkh
2022-08-08 13:25 ` Patch "arm64: set UXN on swapper page tables" has been added to the 5.18-stable tree gregkh
2022-08-08 13:26 ` Patch "arm64: set UXN on swapper page tables" has been added to the 5.19-stable tree gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvEOa/l7zcukaqle@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pcc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.