All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson via Linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org>
To: Coleman Dietsch <dietschc@csp.edu>
Cc: x86@kernel.org, kvm@vger.kernel.org,
	Pavel Skripkin <paskripkin@gmail.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v3 1/2] KVM: x86/xen: Initialize Xen timer only once
Date: Tue, 9 Aug 2022 00:32:33 +0000	[thread overview]
Message-ID: <YvGrIRlJThFoLPsb@google.com> (raw)
In-Reply-To: <20220808190607.323899-2-dietschc@csp.edu>

On Mon, Aug 08, 2022, Coleman Dietsch wrote:
> Add a check for existing xen timers before initializing a new one.
> 
> Currently kvm_xen_init_timer() is called on every
> KVM_XEN_VCPU_ATTR_TYPE_TIMER, which is causing the following ODEBUG
> crash when vcpu->arch.xen.timer is already set.
> 
> ODEBUG: init active (active state 0)
> object type: hrtimer hint: xen_timer_callbac0
> RIP: 0010:debug_print_object+0x16e/0x250 lib/debugobjects.c:502
> Call Trace:
> __debug_object_init
> debug_hrtimer_init
> debug_init
> hrtimer_init
> kvm_xen_init_timer
> kvm_xen_vcpu_set_attr
> kvm_arch_vcpu_ioctl
> kvm_vcpu_ioctl
> vfs_ioctl
> 
> Fixes: 536395260582 ("KVM: x86/xen: handle PV timers oneshot mode")
> Cc: stable@vger.kernel.org
> Link: https://syzkaller.appspot.com/bug?id=8234a9dfd3aafbf092cc5a7cd9842e3ebc45fc42
> Reported-by: syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com
> Signed-off-by: Coleman Dietsch <dietschc@csp.edu>
> ---

Reviewed-by: Sean Christopherson <seanjc@google.com>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Coleman Dietsch <dietschc@csp.edu>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
	Pavel Skripkin <paskripkin@gmail.com>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	stable@vger.kernel.org,
	syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com
Subject: Re: [PATCH v3 1/2] KVM: x86/xen: Initialize Xen timer only once
Date: Tue, 9 Aug 2022 00:32:33 +0000	[thread overview]
Message-ID: <YvGrIRlJThFoLPsb@google.com> (raw)
In-Reply-To: <20220808190607.323899-2-dietschc@csp.edu>

On Mon, Aug 08, 2022, Coleman Dietsch wrote:
> Add a check for existing xen timers before initializing a new one.
> 
> Currently kvm_xen_init_timer() is called on every
> KVM_XEN_VCPU_ATTR_TYPE_TIMER, which is causing the following ODEBUG
> crash when vcpu->arch.xen.timer is already set.
> 
> ODEBUG: init active (active state 0)
> object type: hrtimer hint: xen_timer_callbac0
> RIP: 0010:debug_print_object+0x16e/0x250 lib/debugobjects.c:502
> Call Trace:
> __debug_object_init
> debug_hrtimer_init
> debug_init
> hrtimer_init
> kvm_xen_init_timer
> kvm_xen_vcpu_set_attr
> kvm_arch_vcpu_ioctl
> kvm_vcpu_ioctl
> vfs_ioctl
> 
> Fixes: 536395260582 ("KVM: x86/xen: handle PV timers oneshot mode")
> Cc: stable@vger.kernel.org
> Link: https://syzkaller.appspot.com/bug?id=8234a9dfd3aafbf092cc5a7cd9842e3ebc45fc42
> Reported-by: syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com
> Signed-off-by: Coleman Dietsch <dietschc@csp.edu>
> ---

Reviewed-by: Sean Christopherson <seanjc@google.com>

  parent reply	other threads:[~2022-08-09  0:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 19:06 [PATCH v3 1/2] KVM: x86/xen: Initialize Xen timer only once Coleman Dietsch
2022-08-08 19:06 ` Coleman Dietsch
2022-08-08 19:06 ` [PATCH v3 2/2] KVM: x86/xen: Stop Xen timer before changing IRQ Coleman Dietsch
2022-08-08 19:06   ` Coleman Dietsch
2022-08-09  0:34   ` Sean Christopherson via Linux-kernel-mentees
2022-08-09  0:34     ` Sean Christopherson
2022-08-09  9:22   ` David Woodhouse
2022-08-09  9:22     ` David Woodhouse
2022-08-09 12:59     ` Paolo Bonzini
2022-08-09 12:59       ` Paolo Bonzini
2022-08-09 13:51       ` David Woodhouse
2022-08-09 13:51         ` David Woodhouse
2022-08-09 14:07         ` Sean Christopherson via Linux-kernel-mentees
2022-08-09 14:07           ` Sean Christopherson
2022-08-09 14:16           ` David Woodhouse
2022-08-09 14:16             ` David Woodhouse
2022-08-09 14:31             ` Paolo Bonzini
2022-08-09 14:31               ` Paolo Bonzini
2022-08-09 14:36               ` David Woodhouse
2022-08-09 14:36                 ` David Woodhouse
2022-08-09 14:40               ` Sean Christopherson via Linux-kernel-mentees
2022-08-09 14:40                 ` Sean Christopherson
2022-08-09 14:52                 ` David Woodhouse
2022-08-09 14:52                   ` David Woodhouse
2022-08-09  0:32 ` Sean Christopherson via Linux-kernel-mentees [this message]
2022-08-09  0:32   ` [PATCH v3 1/2] KVM: x86/xen: Initialize Xen timer only once Sean Christopherson
2022-08-09 12:59   ` Paolo Bonzini
2022-08-09 12:59     ` Paolo Bonzini
  -- strict thread matches above, loose matches on Subject: below --
2022-08-08 19:02 [PATCH v3 0/2] KVM: x86/xen: Prevent Xen timer init when running Coleman Dietsch
2022-08-08 19:02 ` [PATCH v3 1/2] KVM: x86/xen: Initialize Xen timer only once Coleman Dietsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvGrIRlJThFoLPsb@google.com \
    --to=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dietschc@csp.edu \
    --cc=hpa@zytor.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paskripkin@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.