From: Andrew Lunn <andrew@lunn.ch>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Marek Behún" <kabel@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 1/4] pinctrl: armada-37xx: Add missing GPIO-only pins
Date: Tue, 9 Aug 2022 22:41:33 +0200 [thread overview]
Message-ID: <YvLGfU1LRbjmGEU4@lunn.ch> (raw)
In-Reply-To: <20220809203648.uxxgpe7q4jg4qvvf@pali>
On Tue, Aug 09, 2022 at 10:36:48PM +0200, Pali Rohár wrote:
> On Tuesday 09 August 2022 22:24:12 Andrew Lunn wrote:
> > On Fri, Aug 05, 2022 at 02:21:59PM +0200, Pali Rohár wrote:
> > > gpio1_5 and gpio2_2 are GPIO-only pins. Add them into MPP groups table
> > > so they are properly exported as valid pin numbers.
> > >
> > > Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx")
> >
> > Does this actually break anything? Are there boards in mainline that
> > require this? Does this need to be part of stable?
> >
> > Andrew
>
> I'm not adding CC:stable tag for automatic stable backporting. I'm
> adding just Fixes tag to indicate that this patch fixes above mentioned
> commit.
O.K.
It might get back ported anyway, due to the fuzzy logic bot thinking
its a valuable fix.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Marek Behún" <kabel@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 1/4] pinctrl: armada-37xx: Add missing GPIO-only pins
Date: Tue, 9 Aug 2022 22:41:33 +0200 [thread overview]
Message-ID: <YvLGfU1LRbjmGEU4@lunn.ch> (raw)
In-Reply-To: <20220809203648.uxxgpe7q4jg4qvvf@pali>
On Tue, Aug 09, 2022 at 10:36:48PM +0200, Pali Rohár wrote:
> On Tuesday 09 August 2022 22:24:12 Andrew Lunn wrote:
> > On Fri, Aug 05, 2022 at 02:21:59PM +0200, Pali Rohár wrote:
> > > gpio1_5 and gpio2_2 are GPIO-only pins. Add them into MPP groups table
> > > so they are properly exported as valid pin numbers.
> > >
> > > Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for Armada 37xx")
> >
> > Does this actually break anything? Are there boards in mainline that
> > require this? Does this need to be part of stable?
> >
> > Andrew
>
> I'm not adding CC:stable tag for automatic stable backporting. I'm
> adding just Fixes tag to indicate that this patch fixes above mentioned
> commit.
O.K.
It might get back ported anyway, due to the fuzzy logic bot thinking
its a valuable fix.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-09 20:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 12:21 [PATCH v2 1/4] pinctrl: armada-37xx: Add missing GPIO-only pins Pali Rohár
2022-08-05 12:21 ` Pali Rohár
2022-08-05 12:22 ` [PATCH v2 2/4] pinctrl: armada-37xx: Fix definitions for MPP pins 20-22 Pali Rohár
2022-08-05 12:22 ` Pali Rohár
2022-08-09 20:22 ` Andrew Lunn
2022-08-09 20:22 ` Andrew Lunn
2022-08-05 12:22 ` [PATCH v2 3/4] pinctrl: armada-37xx: Checks for errors in gpio_request_enable callback Pali Rohár
2022-08-05 12:22 ` Pali Rohár
2022-08-05 12:22 ` [PATCH v2 4/4] pinctrl: armada-37xx: Remove unused macro PIN_GRP() Pali Rohár
2022-08-05 12:22 ` Pali Rohár
2022-08-09 20:24 ` Andrew Lunn
2022-08-09 20:24 ` Andrew Lunn
2022-08-09 20:19 ` [PATCH v2 1/4] pinctrl: armada-37xx: Add missing GPIO-only pins Andrew Lunn
2022-08-09 20:19 ` Andrew Lunn
2022-08-09 20:23 ` Pali Rohár
2022-08-09 20:23 ` Pali Rohár
2022-08-09 20:24 ` Andrew Lunn
2022-08-09 20:24 ` Andrew Lunn
2022-08-09 20:36 ` Pali Rohár
2022-08-09 20:36 ` Pali Rohár
2022-08-09 20:41 ` Andrew Lunn [this message]
2022-08-09 20:41 ` Andrew Lunn
2022-08-22 8:47 ` Linus Walleij
2022-08-22 8:47 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvLGfU1LRbjmGEU4@lunn.ch \
--to=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=kabel@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=pali@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.